DataGrid - cellRender triggers a second request on loading an initial page (T1326786)#34180
Open
markallenramirez wants to merge 3 commits into
Open
DataGrid - cellRender triggers a second request on loading an initial page (T1326786)#34180markallenramirez wants to merge 3 commits into
markallenramirez wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets DataGrid virtual scrolling behavior to prevent cellRender from triggering an extra data request during the initial page load by changing when viewport-driven load parameter changes are detected.
Changes:
- Updated virtual scrolling logic to compute and compare “current” vs “loaded” page parameters via extracted flags (
isViewportChanging,isNotLoading,loadParamsChanged). - Tightened the condition for treating load params as “changed” by additionally requiring
_viewportChanging.
Comment on lines
+1034
to
+1038
| const isNotLoading = !this._isLoading; | ||
| const loadParamsChanged = pageIndex !== loadedPageParams.pageIndex || loadPageCount !== loadedPageParams.loadPageCount; | ||
| let result: any = null; | ||
|
|
||
| if (!this._isLoading && pageIndexIsValid && (pageIndex !== loadedPageParams.pageIndex || loadPageCount !== loadedPageParams.loadPageCount)) { | ||
| if (isViewportChanging && isNotLoading && pageIndexIsValid && loadParamsChanged) { |
Comment on lines
+1034
to
+1038
| const isNotLoading = !this._isLoading; | ||
| const loadParamsChanged = pageIndex !== loadedPageParams.pageIndex || loadPageCount !== loadedPageParams.loadPageCount; | ||
| let result: any = null; | ||
|
|
||
| if (!this._isLoading && pageIndexIsValid && (pageIndex !== loadedPageParams.pageIndex || loadPageCount !== loadedPageParams.loadPageCount)) { | ||
| if (isViewportChanging && isNotLoading && pageIndexIsValid && loadParamsChanged) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.