Scheduler - A11y - remove tabindex attr from workspace and header#34205
Open
bit-byte0 wants to merge 6 commits into
Open
Scheduler - A11y - remove tabindex attr from workspace and header#34205bit-byte0 wants to merge 6 commits into
bit-byte0 wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes tabindex from the Scheduler workspace and header root elements (A11y), shifting keyboard focus management to individual workspace cells and updating internal keyboard/focus handling accordingly.
Changes:
- Override
_renderFocusTarget()in workspace and header to preventtabIndex/tabindexfrom being rendered on root elements. - Add cell-level focusing in the workspace (track focused cell, set
tabindex="-1", and programmatically focus the cell on click/keyboard navigation). - Consolidate/relocate Scheduler unit tests and extend the test POM with
getHeader()/getWorkSpace()helpers.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/scheduler/workspaces/work_space.ts | Disables root focus target rendering, adds keyboard attachment override, and implements cell-level focusing behavior. |
| packages/devextreme/js/__internal/scheduler/header/header.ts | Disables root focus target rendering to remove tabindex from the header element. |
| packages/devextreme/js/__internal/scheduler/tests/workspace.test.ts | New consolidated workspace tests, including new A11y and keyboard-focus assertions. |
| packages/devextreme/js/__internal/scheduler/tests/workspace.recalculation.test.ts | Removed (test moved into workspace.test.ts). |
| packages/devextreme/js/__internal/scheduler/tests/toolbar_adaptivity.test.ts | Removed (test moved into header.test.ts). |
| packages/devextreme/js/__internal/scheduler/tests/header.test.ts | New header tests covering A11y and toolbar adaptivity expectations. |
| packages/devextreme/js/__internal/scheduler/tests/mock/model/scheduler.ts | Extends the Scheduler test model with getHeader() and getWorkSpace() accessors. |
| packages/devextreme/eslint-scheduler-allowlist.mjs | Allows the new _attachKeyboardEvents override in Scheduler workspace. |
… POM getters, tabIndex casing
sjbur
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.