fix(pre-push): mirror CI gate — run all tests, drop coverage gate#257
Merged
Conversation
The pre-push hook ran 'pytest tests/', which picks up the addopts '-m not slow' filter and the --cov-fail-under=86 gate. That diverged from CI (.github/workflows/tests.yml), which runs 'pytest -m '' --no-cov' — all tests, no coverage gate. Two consequences: - Slow tests CI runs were skipped locally, so a CI-failing slow test could still print a local '✓ passed'. - The local-only coverage gate could abort a push CI would accept (e.g. transient measurement dips), the asymmetry that bites. Now mirror CI exactly: pytest -m '' --no-cov. Co-Authored-By: Max <noreply>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The pre-push hook ran
pytest tests/, which picks up the addopts-m 'not slow'filter and the--cov-fail-under=86gate. That diverged from CI (.github/workflows/tests.yml), which runspytest -m '' --no-cov— all tests, no coverage gate.Two consequences:
✓ passed(false confidence).Change
Hook now runs
pytest -m '' --no-cov --tb=short— exactly CI's criterion. Verified locally: 3073 passed, 34 skipped, exit 0 (~2m12s).🤖 Generated by Max — the hook that guards the gate should know where the gate is.