Skip to content

fix: codegen error on layers extend#274

Open
cpreston321 wants to merge 4 commits intoDiizzayy:mainfrom
cpreston321:fix/codegenErrorDev
Open

fix: codegen error on layers extend#274
cpreston321 wants to merge 4 commits intoDiizzayy:mainfrom
cpreston321:fix/codegenErrorDev

Conversation

@cpreston321
Copy link
Copy Markdown
Contributor

@cpreston321 cpreston321 commented Dec 8, 2022

fixes: #271

@Diizzayy what basically happen'd -- it was watching on all paths of extend even in node_modules/ folder that would not map to any client docs then error out but where all the same file. To resolve this we block all unlink events and path changes in ../ that basically represent the theme it's extending in watch mode.

example of event:

✔ Nitro built in 420 ms                                                                                                                         nitro 10:02:50
[add] PATH:  ../basic/node_modules/nuxt-graphql-client/examples/extends/queries/test2.gql                                                             10:03:00
allowDocument:  true                                                                                                                                  10:03:00
[add] PATH:  ../basic/node_modules/nuxt-graphql-client/playground/node_modules/nuxt-graphql-client/examples/extends/queries/test2.gql                 10:03:00
allowDocument:  true                                                                                                                                  10:03:00
[unlink] PATH:  queries/test1.gql 

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 8, 2022

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.25%. Comparing base (7207c06) to head (a4a9bb7).
⚠️ Report is 79 commits behind head on main.

Files with missing lines Patch % Lines
src/module.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   93.70%   93.25%   -0.46%     
==========================================
  Files           6        6              
  Lines         620      623       +3     
  Branches      122      122              
==========================================
  Hits          581      581              
- Misses         39       42       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Diizzayy Diizzayy self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhandled Codegen error on create of .gql|graphql file in dev.

2 participants