test: parameterise migration error-status cases#43
Merged
Conversation
Fold the near-identical invalid_url (400) and not_imported (404) cases into a single it.each, addressing review feedback on PR #42. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
doistbot
reviewed
Jun 26, 2026
doistbot
left a comment
doistbot
left a comment
Member
There was a problem hiding this comment.
This PR updates test: parameterise migration error-status cases. No issues were flagged in the reviewed diff.
Member
|
👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #42 addressing Amir's review nit: parameterise the migration test suite.
The two near-identical
fetchNewCommsUrlerror cases —invalid_url(400) andnot_imported(404) — are folded into a singleit.each, which is more concise and makes the status/code matrix easier to scan. The 500 case stays separate as it asserts a different shape (instanceofonly). Still 8 tests, all passing.🤖 Generated with Claude Code