fix: show API key field for Ollama providers and pass apiKey to createOllama#4685
Open
sathia27 wants to merge 1 commit into
Open
fix: show API key field for Ollama providers and pass apiKey to createOllama#4685sathia27 wants to merge 1 commit into
sathia27 wants to merge 1 commit into
Conversation
pass apiKey to createOllama
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR fixes the AI provider configuration for Ollama Cloud and other authenticated Ollama endpoints. Previously, the API key input was hidden whenever the provider URL was detected as Ollama, preventing users from entering credentials. The backend also never forwarded the stored API key to
createOllama. This change renders the API key field unconditionally and passes the key to the Ollama provider.Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #4684
Screenshots (if applicable)
Before fix
After fix