FIX: we must retrieve linked order_supplier and no other object#33602
Merged
eldy merged 3 commits intoDolibarr:20.0from Mar 26, 2025
Merged
FIX: we must retrieve linked order_supplier and no other object#33602eldy merged 3 commits intoDolibarr:20.0from
eldy merged 3 commits intoDolibarr:20.0from
Conversation
Contributor
Author
|
Hey there, @eldy (or any Travis CI expert). I fail to understand why Travis can’t build. The error states that when fetching a Reception object with id = 1, it was not found (return of the fetch method = 0), which seems fine to me, as I don’t know that there should be such a reception in db. Is that related to my modification, and in which way ? |
Contributor
Author
|
Maybe @frederic34 would know why Travis is so mean to me ! |
Member
|
@altairis-noe on your example can you remove link to order_supplier and see what happen with your change |
Contributor
Author
|
Good point ! As Reception are created from a Purchase order, I would not have thought about what would happen in case they don’t have an originating one… Thx @frederic34 |
frederic34
reviewed
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX we must retrieve linked order_supplier and no other object
If we want to link objects different than a CommandeFournisseur to a Reception object, we get an ugly error, because fetch->origin will try to fetch… well, not the actual origin!
With this correction: here we go!
