Show all filament and manufacturer fields in the library detail views - #999
Merged
Conversation
The spool view's filament section only listed the specs, and neither the spool nor the filament view showed anything of the manufacturer beyond its name. Fill both in, and render URLs in text fields as links. - Spool view's filament section gains price, article number, external id, registered and comment, and always shows spool weight. - New read-only VendorSection, shown in both the spool and filament views, with the manufacturer's fields and extra fields plus a link to it. - Any URL in a comment or text extra field is now a link opening in a new tab with rel="nofollow noopener": inline in read-only values, and as an icon beside the input where the value stays editable. Fixes #992
In the spool view the filament's custom fields sat under their own "Extra fields" heading, styled exactly like the FILAMENT and MANUFACTURER headings beside it, so it read as a third peer section rather than as more of the filament. Emit those rows straight into the preceding field grid instead. Only the read-only mirrors change; an entity's own extra-fields section keeps its heading, which is also where the "Manage fields" link lives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #992.
The spool view's filament section only listed the specs, and neither the spool nor the filament view showed anything of the manufacturer beyond its name.
Only http(s) and www. forms are linked, so a value can never produce a javascript: or data: href. Trailing sentence punctuation and wrapping parens are trimmed off the match.
The mirrored extra fields are emitted as rows of the section's own field grid rather than under their own "Extra fields" heading, which otherwise reads as a peer of FILAMENT and MANUFACTURER. Sections that own their extra fields keep the heading and its "Manage fields" link.