verifier: report attestation mode#759
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the verifier’s response schema to report the attestation mode (as the AttestationMode serde string) rather than a custom “TEE platform” string, aligning the output with the underlying attestation types.
Changes:
- Rename verifier output field from
details.tee_platformtodetails.attestation_mode. - Populate
attestation_modedirectly from the verified quote’smode()(e.g.,dstack-tdx,dstack-gcp-tdx,dstack-nitro-enclave,dstack-amd-sev-snp). - Update verifier tests and README documentation to reflect the new field and values.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| verifier/src/verification.rs | Removes custom platform-name mapping and sets details.attestation_mode from the verified quote mode; updates related assertions in tests. |
| verifier/src/types.rs | Changes VerificationDetails schema from tee_platform: Option<String> to attestation_mode: Option<AttestationMode>. |
| verifier/README.md | Updates example output and field documentation to use attestation_mode and the AttestationMode serde strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
details.tee_platformtodetails.attestation_modeAttestationModedirectly (for exampledstack-tdx,dstack-gcp-tdx,dstack-nitro-enclave,dstack-amd-sev-snp)Testing
cargo fmt --checkcargo check -p dstack-verifiercargo test -p dstack-verifier