Skip to content

verifier: report attestation mode#759

Merged
kvinwang merged 1 commit into
masterfrom
codex/verifier-attestation-mode
Jul 8, 2026
Merged

verifier: report attestation mode#759
kvinwang merged 1 commit into
masterfrom
codex/verifier-attestation-mode

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • rename verifier output details.tee_platform to details.attestation_mode
  • report the serde representation of AttestationMode directly (for example dstack-tdx, dstack-gcp-tdx, dstack-nitro-enclave, dstack-amd-sev-snp)
  • update verifier tests and README references

Testing

  • cargo fmt --check
  • cargo check -p dstack-verifier
  • cargo test -p dstack-verifier

Copilot AI review requested due to automatic review settings July 8, 2026 10:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the verifier’s response schema to report the attestation mode (as the AttestationMode serde string) rather than a custom “TEE platform” string, aligning the output with the underlying attestation types.

Changes:

  • Rename verifier output field from details.tee_platform to details.attestation_mode.
  • Populate attestation_mode directly from the verified quote’s mode() (e.g., dstack-tdx, dstack-gcp-tdx, dstack-nitro-enclave, dstack-amd-sev-snp).
  • Update verifier tests and README documentation to reflect the new field and values.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
verifier/src/verification.rs Removes custom platform-name mapping and sets details.attestation_mode from the verified quote mode; updates related assertions in tests.
verifier/src/types.rs Changes VerificationDetails schema from tee_platform: Option<String> to attestation_mode: Option<AttestationMode>.
verifier/README.md Updates example output and field documentation to use attestation_mode and the AttestationMode serde strings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kvinwang kvinwang merged commit bdc3999 into master Jul 8, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants