Skip to content

fix exact Gateway approval waiter settlement - #2681

Merged
wtj-0527 merged 6 commits into
EKKOLearnAI:mainfrom
wtj-0527:fix/2680-exact-gateway-approval-waiter
Aug 23, 2026
Merged

fix exact Gateway approval waiter settlement#2681
wtj-0527 merged 6 commits into
EKKOLearnAI:mainfrom
wtj-0527:fix/2680-exact-gateway-approval-waiter

Conversation

@wtj-0527

Copy link
Copy Markdown
Collaborator

Summary

  • retain the Hermes Runtime Gateway request_id beside the exact Session and Group Run generation
  • resolve interrupted and user-answered Gateway approvals by that exact request ID instead of Session FIFO
  • cover an older waiter ahead of the interrupted waiter while preserving other Sessions and later Runs

Closes #2680

Validation

  • npm run test -- tests/server/agent-bridge-python-concurrency.test.ts tests/server/agent-bridge-client-boundary-interrupt.test.ts tests/server/group-chat-approval.test.ts tests/server/group-chat-agent-workspace.test.ts (116 passed)
  • npx playwright test tests/e2e/group-chat-room-deeplink.spec.ts --grep "removes an interrupted run approval" --project=chromium (1 passed)
  • npm run harness:check
  • npm run build
  • git diff --check

Safety

  • tests use only harmless printf approval payloads and never execute the pending commands
  • no merge, release, packaging, install, deployment, or restart is included

@wtj-0527
wtj-0527 merged commit c8d8cc3 into EKKOLearnAI:main Aug 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(group-chat): settle the exact Gateway approval waiter on force-stop

1 participant