Skip to content

Phase 3: core/shell/proxy#140

Merged
teresa-ortega merged 9 commits intonext-genfrom
teresa-ortega/core-shell-proxy
Apr 15, 2026
Merged

Phase 3: core/shell/proxy#140
teresa-ortega merged 9 commits intonext-genfrom
teresa-ortega/core-shell-proxy

Conversation

@teresa-ortega
Copy link
Copy Markdown
Collaborator

@teresa-ortega teresa-ortega commented Apr 7, 2026

Proposed changes

A ShellProxy class under the shell/ subpackage as a first step towards a full shell abstraction layer. Commands like

ctx.shell.ros2.launch(...)
ctx.shell.evo_ape.bag2(...)
print [CMD]: <full command> 

to stdout instead of executing anything. The interface is fully generic, making it easily extensible and keeping benchmark code unchanged when swapping in a real shell implementation later.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 No breaking changes.

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Additional comments

N/A

@teresa-ortega teresa-ortega requested a review from xaru8145 April 7, 2026 13:50
@teresa-ortega teresa-ortega changed the title initial implementation Phase 3: core/shell/proxy Apr 7, 2026
@teresa-ortega teresa-ortega force-pushed the teresa-ortega/core-shell-proxy branch from 28460cb to 2ff15a5 Compare April 8, 2026 12:34
Comment thread src/lambkin/core/shell/proxy.py
Comment thread src/lambkin/core/shell/proxy.py
Comment thread test/core/test_shell.py
Comment thread src/lambkin/core/shell/proxy.py
Comment thread src/lambkin/core/shell/proxy.py Outdated
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
@teresa-ortega teresa-ortega force-pushed the teresa-ortega/core-shell-proxy branch from 1022aef to e9c7343 Compare April 14, 2026 15:17
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
@teresa-ortega teresa-ortega requested a review from xaru8145 April 15, 2026 11:15
@teresa-ortega teresa-ortega marked this pull request as ready for review April 15, 2026 11:25
Comment thread examples/beluga/beluga_benchmark.py Outdated
Comment thread src/lambkin/core/shell/proxy.py
…n is False

Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
@teresa-ortega teresa-ortega requested a review from xaru8145 April 15, 2026 12:13
Copy link
Copy Markdown
Collaborator

@xaru8145 xaru8145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, final fix required.

Comment thread examples/beluga/beluga_benchmark.py Outdated
Comment thread src/lambkin/core/ctx/context.py Outdated
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
@teresa-ortega teresa-ortega requested a review from xaru8145 April 15, 2026 15:13
Copy link
Copy Markdown
Collaborator

@xaru8145 xaru8145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Now that we have worked on the foundation of the SDK, it's a good idea to start creating tests that combine the different elements to assert hidden issues and verify integration.

We want to avoid having to manually test everything via the beluga benchmark example.

@teresa-ortega teresa-ortega merged commit b510c3e into next-gen Apr 15, 2026
4 checks passed
@teresa-ortega teresa-ortega deleted the teresa-ortega/core-shell-proxy branch April 15, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants