Merged
Conversation
28460cb to
2ff15a5
Compare
xaru8145
requested changes
Apr 14, 2026
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
1022aef to
e9c7343
Compare
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
xaru8145
requested changes
Apr 15, 2026
…n is False Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
xaru8145
requested changes
Apr 15, 2026
Collaborator
xaru8145
left a comment
There was a problem hiding this comment.
Almost there, final fix required.
Signed-off-by: Maria Teresa Ortega <teresa.ortega0903@gmail.com>
xaru8145
approved these changes
Apr 15, 2026
Collaborator
xaru8145
left a comment
There was a problem hiding this comment.
LGTM.
Now that we have worked on the foundation of the SDK, it's a good idea to start creating tests that combine the different elements to assert hidden issues and verify integration.
We want to avoid having to manually test everything via the beluga benchmark example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
A ShellProxy class under the shell/ subpackage as a first step towards a full shell abstraction layer. Commands like
to stdout instead of executing anything. The interface is fully generic, making it easily extensible and keeping benchmark code unchanged when swapping in a real shell implementation later.
Type of change
💥 No breaking changes.
Checklist
Put an
xin the boxes that apply. This is simply a reminder of what we will require before merging your code.Additional comments
N/A