Apply feedback from Javi, Mich and Gera#31
Merged
JesusSilvaUtrera merged 8 commits intomainfrom Oct 28, 2025
Merged
Conversation
Collaborator
Author
|
I still need to refine the solution for Exercise 4, I changed a bit the exercise using Mich's feedback |
Collaborator
Author
|
specific-ci passed when it shouldn't, but tests are failing inside if you take a look to the logs |
Collaborator
Author
Tested, new solution is working |
xaru8145
requested changes
Oct 27, 2025
xaru8145
changed the title
xaru8145
reviewed
Oct 27, 2025
xaru8145
force-pushed
the
feature/apply-feedback
branch
from
394fc0b to
22e6643
Compare
xaru8145
reviewed
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Apply the feedback received from Javi and Mich.
Points that weren't tackled:
Type
How to test
Steps to reproduce / test the changes:
Checklist
git commit -s) or added Signed-off-by to existing commits.