Fix docker configuration - rename dockerignore file#32
Merged
JesusSilvaUtrera merged 1 commit intomainfrom Oct 28, 2025
Merged
Conversation
Collaborator
Author
|
Can you check this on your end and verify it works @JesusSilvaUtrera ? |
05aea1c to
1e2d63a
Compare
JesusSilvaUtrera
approved these changes
Oct 28, 2025
Collaborator
JesusSilvaUtrera
left a comment
There was a problem hiding this comment.
LGTM, I tested without mounting the vollumes and only the package.xml of the packages is present, not the source code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The current docker image contains the source code and the READMEs because the
.dockerignorefile was not being properly processed.That is because unfortunately the docker ignore file needs to be in root of the build context directory and cannot live in subdirectories like
docker/in our case [Source].A workaround to keep the file inside the
dockerfolder, you can define a dockerignore file that has the same name as the docker file. From here:For our case, the elegant solution IMO is to rename
.dockerignoretoDockerfile.dockerignorerather than moving.dockerignoreone directory up so it is in the root of the build context.Type
How to test
Steps to reproduce / test the changes:
Checklist
git commit -s) or added Signed-off-by to existing commits.Related issues