Apply feedback from internal workshop#37
Merged
JesusSilvaUtrera merged 20 commits intomainfrom Oct 31, 2025
Merged
Conversation
6 tasks
…the container is started
…ght up in the internal workshop
…e exercise -> simplification to gain time
xaru8145
force-pushed
the
feature/apply_internal_workshop_feedback
branch
from
c2a19cc to
5f73cab
Compare
Collaborator
|
@xaru8145 take a look to see if anything else is missing, to merge this and send the request to make it open-source |
Collaborator
JesusSilvaUtrera
left a comment
JesusSilvaUtrera
left a comment
There was a problem hiding this comment.
Just leaving a comment, rest looks fine
xaru8145
commented
Oct 31, 2025
Collaborator
Author
xaru8145
left a comment
xaru8145
left a comment
There was a problem hiding this comment.
Missing LICENSE file
Collaborator
Author
Added License in 7d3e055 |
JesusSilvaUtrera
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Apply feedback from the internal workshop hosted online on 29/10/2025.
Module 2:
roi_filterfunction in so it is no longer part of the exercise in favor of speeding up workshop flow.Module 3:
test_laser_detector.cpp.Type
How to test
Steps to reproduce / test the changes:
Checklist
git commit -s) or added Signed-off-by to existing commits.Related issues
N/A