test(cli): cover Agent Skills expectations criteria#1617
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
c7d7048
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://88efeb01.agentv.pages.dev |
| Branch Preview URL: | https://task-av-p60u-agent-skills-ex.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expectationswithoutassertions.agent-skills-criteriallm-rubric entries with stableexpectation-NIDs andrequired: true.Notes
Latest
origin/mainalready moved Agent Skills evals.json support out of the removed core loader and into the CLI read adapter, and it already parsesexpectations. This PR preserves that behavior with focused expectations-only coverage.Verification
bun test apps/cli/test/commands/convert/convert-evals-json.test.ts- passbun run lint- passgit diff --check- passbun test packages/core/test/evaluation/orchestrator.test.ts -t "applies exponential backoff between retries"- pass after full-suite timing failurebun run test- one timing-sensitive failure inpackages/core/test/evaluation/orchestrator.test.ts(applies exponential backoff between retries); reran that exact test successfullyReview
Subagent review reported no findings. Residual gap noted: this new case exercises the read-adapter object path; the existing basic conversion test already covers serialized YAML for
expectationswhenassertionsare also present.Closes av-p60u.