Fix oversized kit leftovers being dropped unsplit#6580
Open
BD9a wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #6579.
Details
Proposed fix:
Split kit leftovers before dropping them into the world.
When
drop-items-if-fullis enabled, leftover kit items may already be normalized into oversized internalItemStacks. The fix clones each leftover stack and drops it in chunks no larger than the item's normal max stack size instead of passing the original leftover stack directly todropItemNaturally.This preserves the existing inventory insertion behavior, but prevents oversized leftover stacks such as
OBSIDIAN x128from becoming item entities.Environments tested:
OS: Linux
Java version: 25.0.3
Most recent Paper version (1.21.4, git-Paper-BUILD)CraftBukkit/Spigot/Paper 1.12.2CraftBukkit 1.8.8Demonstration: