Optimize bulk reader setup and harden SQL performance comparisons#213
Optimize bulk reader setup and harden SQL performance comparisons#213PrzemyslawKlys wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 475797a864
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 52.78% 52.79% +0.01%
==========================================
Files 208 208
Lines 16097 16094 -3
Branches 2846 2847 +1
==========================================
+ Hits 8496 8497 +1
+ Misses 6758 6755 -3
+ Partials 843 842 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@codex please review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43cddbad45
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
IDataReaderschema and column metadata once, then reuse it for validation, destination creation, and bulk-copy mappingsPerformance
For 100,000-row SQL-to-CSV export, the direct DbaClientX reader completes in about 60 ms versus dbatools at 87 ms and bcp at 142 ms. At 25,000 rows, DbaClientX leads dbatools by 1.33x for DataTable reads, 2.03x for PowerShell-object reads, and 1.51x to 5.70x across equivalent write shapes.
Validation
Windows and WSL .NET/Pester suites, live SQL correctness checks, typed Office round trips, package creation, packaged assembly-load isolation, and source-binary provenance pass. The SQL data-movement, direct CSV-export, and Office round-trip specs produce non-empty plans through the source-built PowerForge gate surface; the single-engine Office plan also passes under PowerShell 7 and Windows PowerShell 5.1.
Dependency order
The fastest-baseline assertion first ships in PSPublishModule
3.0.64through EvotecIT/PSPublishModule#551. Until that release exists, use the source-built module for development; merge and release the shared PowerForge change before treating the updated benchmark specs as independently consumable. No package publication is part of this PR.