Skip to content

Harden desktop automation, persistence, and release packaging#184

Merged
PrzemyslawKlys merged 6 commits into
v2-speedygonzalesfrom
codex/fix-audit-findings
Jul 15, 2026
Merged

Harden desktop automation, persistence, and release packaging#184
PrzemyslawKlys merged 6 commits into
v2-speedygonzalesfrom
codex/fix-audit-findings

Conversation

@PrzemyslawKlys

@PrzemyslawKlys PrzemyslawKlys commented Jul 14, 2026

Copy link
Copy Markdown
Member

Summary

  • harden MCP protocol handling and safety metadata, including current newline-delimited transport, strict request validation, and blocking global desktop mutations under process filters
  • correct monitor positioning, make state writes atomic, reject ambiguous persisted names, and keep diagnostics off MCP stdout
  • remove per-call COM/UI Automation/HTTP overhead, bound caches, and replace pixel-by-pixel bitmap access with buffered scanning
  • align PowerShell, CLI, examples, generated docs, workflows, and PowerForge packaging with the supported product contracts

Compatibility changes

  • removes Set-DesktopDpiScaling and related CLI/core APIs because Windows has no supported public per-monitor setter for this user setting
  • changes monitor positioning to left and top only; resolution remains a separate operation
  • updates MCP stdio to the 2025-06-18 newline-delimited transport and rejects JSON-RPC batch arrays

Packaging and release state

The reusable packaging correction shipped in PSPublishModule 3.0.59 through EvotecIT/PSPublishModule#545. PSPublishModule 3.0.60 is now public; its tagged commit includes the project-root environment-path correction from EvotecIT/PSPublishModule#547 and passed the Windows, Linux, macOS, and dependency-audit workflows. DesktopManager consumer validation against the public 3.0.60 package resolves its module, app, and MSI configuration correctly.

Local end-to-end packaging produced the app, net8/net10 CLIs, MSI, NuGet package, and PowerShell module; both packaged CLIs start successfully. The configured DesktopManager signing certificate expired on July 6, 2026. Local app and MSI builds therefore keep warning-only signing so developer artifacts remain buildable. Unsigned outputs are not release-ready: a public DesktopManager release remains gated on certificate renewal and must be signed and verified.

Validation

  • .NET: net472 337 passed / 84 skipped; net8 and net10 each 693 passed / 107 skipped
  • PowerShell 5.1 and 7: 67 passed / 1 expected packaged-Core skip on each host
  • targeted MCP safety suite after review fixes: 57 passed on net8.0-windows
  • packaged PowerShell assembly-load-context test passed
  • real PowerForge app/CLI/MSI/NuGet/module build completed with signing disabled only in temporary local proof configuration
  • public PSPublishModule 3.0.60 consumer configuration validation passed
  • workflow YAML and build JSON parse successfully

- correct MCP framing, safety metadata, monitor positioning, and state writes
- reduce bitmap, UI Automation, COM, and wallpaper overhead
- align tests, docs, workflows, and PowerForge packaging with supported contracts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1cac6c1c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/DesktopManager/MonitorService.Display.cs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 52103bf196

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Build/Build-Module.ps1
Comment thread Sources/DesktopManager.Cli/McpCatalog.cs
Comment thread powerforge.dotnetpublish.json Outdated
- classify file-writing screenshot tools as MCP mutations
- preserve warning-only signing for local app and MSI builds
- document the release signature boundary
@PrzemyslawKlys PrzemyslawKlys merged commit 8cf1eba into v2-speedygonzales Jul 15, 2026
6 checks passed
@PrzemyslawKlys PrzemyslawKlys deleted the codex/fix-audit-findings branch July 15, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant