forked from Exiled-Official/EXILED
-
Notifications
You must be signed in to change notification settings - Fork 112
feat: Method to Get wrapper from GameObject & option to not spawn prefab helper networked. #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Saskyc
wants to merge
3
commits into
ExMod-Team:master
Choose a base branch
from
Saskyc:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−4
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -96,8 +96,9 @@ public static T GetPrefab<T>(PrefabType prefabType) | |
| /// <param name="prefabType">The <see cref="PrefabType"/>.</param> | ||
| /// <param name="position">The <see cref="Vector3"/> position where the <see cref="GameObject"/> will spawn.</param> | ||
| /// <param name="rotation">The <see cref="Quaternion"/> rotation of the <see cref="GameObject"/>.</param> | ||
| /// <param name="spawn">Whether the <see cref="PrefabType"/> should be initially spawned.</param> | ||
| /// <returns>Returns the <see cref="GameObject"/> instantied.</returns> | ||
| public static GameObject Spawn(PrefabType prefabType, Vector3 position = default, Quaternion? rotation = null) | ||
| public static GameObject Spawn(PrefabType prefabType, Vector3 position = default, Quaternion? rotation = null, bool spawn = true) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Breaking change. Either switch target branch to dev (for Exiled 10), or make this a separate method |
||
| { | ||
| if (!TryGetPrefab(prefabType, out GameObject gameObject)) | ||
| return null; | ||
|
|
@@ -112,7 +113,8 @@ public static GameObject Spawn(PrefabType prefabType, Vector3 position = default | |
| positionSync.Network_rotationY = (sbyte)Mathf.RoundToInt(rotation.Value.eulerAngles.y / 5.625F); | ||
| } | ||
|
|
||
| NetworkServer.Spawn(newGameObject); | ||
| if (spawn) | ||
| NetworkServer.Spawn(newGameObject); | ||
|
|
||
| return newGameObject; | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.