Skip to content

feat(Player): Player::RemoveItem(ItemType, bool) method #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mr-Baguetter wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

feat(Player): Player::RemoveItem(ItemType, bool) method #801

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0b96f4b
Add: Player::RemoveItem method that uses ItemType instead of a item i…
Mr-Baguetter Apr 3, 2026
f138d36
Updated parameter name
Mr-Baguetter Apr 3, 2026
eb175ff
Updated parameter name
Mr-Baguetter Apr 3, 2026
a910990
Merge branch 'master' of https://github.com/Mr-Baguetter/EXILED
Mr-Baguetter Apr 3, 2026
8fba1b7
Revert param change
Mr-Baguetter Apr 3, 2026
7dd8302
Merge branch 'dev' into master
louis1706 Apr 3, 2026
7aefc66
Added Player::DropItem(ItemType) methods
Mr-Baguetter Apr 6, 2026
09169f4
Merge branch 'master' of https://github.com/Mr-Baguetter/EXILED
Mr-Baguetter Apr 6, 2026
38d5535
Merge branch 'dev' into master
louis1706 May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions EXILED/Exiled.API/Features/Player.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2048,6 +2048,36 @@ public void DropItem(Item item, bool isThrown = false)
/// <returns>dropped <see cref="Pickup"/>.</returns>
public Pickup DropItem(Item item) => item is not null ? Pickup.Get(Inventory.ServerDropItem(item.Serial)) : null;

/// <summary>
/// Drops an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.
/// </summary>
/// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>
/// <param name="isThrown">Is the item Thrown?.</param>
/// <returns>A value indicating whether the <see cref="Item"/> was dropped.</returns>
public bool DropItem(ItemType item, bool isThrown = false)
{
Item itemtodrop = Items.FirstOrDefault(tempItem => tempItem.Type == item);
if (itemtodrop == null)
return false;

DropItem(itemtodrop, isThrown);
return true;
}

/// <summary>
/// Drops an item from the player's inventory.
/// </summary>
/// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>
/// <returns>dropped <see cref="Pickup"/>.</returns>
public Pickup DropItem(ItemType item)
{
Item itemtodrop = Items.FirstOrDefault(tempItem => tempItem.Type == item);
if (itemtodrop == null)
return null;

return Pickup.Get(Inventory.ServerDropItem(itemtodrop.Serial));
}

Comment on lines +2051 to +2080
Copy link
Copy Markdown

@Unbistrackted Unbistrackted Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// <summary>
/// Drops an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.
/// </summary>
/// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>
/// <param name="isThrown">Is the item Thrown?.</param>
/// <returns>A value indicating whether the <see cref="Item"/> was dropped.</returns>
public bool DropItem(ItemType item, bool isThrown = false)
{
Item itemtodrop = Items.FirstOrDefault(tempItem => tempItem.Type == item);
if (itemtodrop == null)
return false;
DropItem(itemtodrop, isThrown);
return true;
}
/// <summary>
/// Drops an item from the player's inventory.
/// </summary>
/// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>
/// <returns>dropped <see cref="Pickup"/>.</returns>
public Pickup DropItem(ItemType item)
{
Item itemtodrop = Items.FirstOrDefault(tempItem => tempItem.Type == item);
if (itemtodrop == null)
return null;
return Pickup.Get(Inventory.ServerDropItem(itemtodrop.Serial));
}
/// <summary>
/// Drops an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.
/// </summary>
/// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>
/// <param name="isThrown">Whether the item should be thrown.</param>
/// <param name="amount">The number of matching items to remove.</param>
/// <returns>A value indicating whether the <see cref="Item"/> was dropped.</returns>
public bool DropItem(ItemType item, bool isThrown = false, int amount = 1)
{
if (amount <= 0)
return false;
List<Item> itemsToDrop = Items.Where(i => i?.Type == item).Take(amount).ToList();
if (itemsToDrop.Count == 0)
return false;
foreach (Item i in itemsToDrop)
DropItem(i, isThrown);
return itemsToDrop.Count > 0;
}
/// <summary>
/// Drops an item from the player's inventory.
/// </summary>
/// <param name="item">The specified <see cref="ItemType"/> to be dropped.</param>
/// <param name="amount">The number of matching items to remove.</param>
/// <returns>A list of dropped <see cref="Pickup"/>s.</returns>
public List<Pickup> DropItem(ItemType item, int amount = 1)
{
List<Pickup> pickups = new();
if (amount <= 0)
return pickups;
List<Item> itemsToDrop = Items.Where(i => i?.Type == item).Take(amount).ToList();
foreach (Item i in itemsToDrop)
pickups.Add(DropItem(i));
return pickups;
}

/// <summary>
/// Drops the held item. Will not do anything if the player is not holding an item.
/// </summary>
Expand Down Expand Up @@ -2155,6 +2185,22 @@ public bool RemoveItem(Item item, bool destroy = true)
return true;
}

/// <summary>
/// Removes an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.
/// </summary>
/// <param name="item">The specified <see cref="ItemType"/> to be removed.</param>
/// <param name="destroy">Whether to destroy the item.</param>
/// <returns>A value indicating whether the <see cref="Item"/> was removed.</returns>
public bool RemoveItem(ItemType item, bool destroy = true)
{
Item itemtoremove = Items.FirstOrDefault(tempItem => tempItem.Type == item);
if (itemtoremove == null)
return false;

RemoveItem(itemtoremove, destroy);
return true;
}

Comment on lines +2188 to +2203
Copy link
Copy Markdown

@Unbistrackted Unbistrackted Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// <summary>
/// Removes an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.
/// </summary>
/// <param name="item">The specified <see cref="ItemType"/> to be removed.</param>
/// <param name="destroy">Whether to destroy the item.</param>
/// <returns>A value indicating whether the <see cref="Item"/> was removed.</returns>
public bool RemoveItem(ItemType item, bool destroy = true)
{
Item itemtoremove = Items.FirstOrDefault(tempItem => tempItem.Type == item);
if (itemtoremove == null)
return false;
RemoveItem(itemtoremove, destroy);
return true;
}
/// <summary>
/// Removes an <see cref="Item"/> from the player's inventory by its <see cref="ItemType"/>.
/// </summary>
/// <param name="item">The specified <see cref="ItemType"/> to be removed.</param>
/// <param name="destroy">Whether to destroy the item.</param>
/// <param name="amount">The number of matching items to remove.</param>
/// <returns>A value indicating whether the <see cref="Item"/> was removed.</returns>
public bool RemoveItem(ItemType item, bool destroy = true, int amount = 1)
{
if (amount <= 0)
return false;
List<Item> itemsToRemove = Items.Where(i => i?.Type == item).Take(amount).ToList();
if (itemsToRemove.Count == 0)
return false;
foreach (Item i in itemsToRemove)
RemoveItem(i, destroy);
return true;
}

/// <summary>
/// Removes an <see cref="Item"/> from the player's inventory.
/// </summary>
Expand Down
Loading