Open
Conversation
added 3 commits
April 2, 2021 23:52
| @@ -0,0 +1,20 @@ | |||
| import "./App.css"; | |||
Contributor
There was a problem hiding this comment.
React jangan lupa di import ya
| <h1 className="hero-text mt-5"> | ||
| Hello Sona, welcome back. <br /> You have tasks to complete | ||
| </h1> | ||
| <img className="img-fluid" src="task.jpg" alt="ilustrasi" /> |
Contributor
There was a problem hiding this comment.
src image di react jangan dimasukan secara hardcode seperti ini.
import imagenya, kemudian srcnya ambil dari image yg di import tadi
Comment on lines
+9
to
+13
| <Task | ||
| task={task} | ||
| deleteTask={deleteTask} | ||
| changeStatus={changeStatus} | ||
| /> |
Contributor
There was a problem hiding this comment.
mapping harus ada props key !!!
Contributor
EddyPermana22
left a comment
EddyPermana22
left a comment
There was a problem hiding this comment.
kodenya sudah lumayan bagus dan bisa dengan mudah untuk dipahami alurnya.
Ada beberapa perbaikan yg perlu dilakukan, contohnya jika melakukan mapping, react component harus punya key yang unik dari setiap harsil mappingnya.
dicoba juga untuk menggunakan ternarry operator untuk memilih komponen yang akan ditampilkan.
EddyPermana22
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://todo-list-sonex.netlify.app/