Inconsistent trailing newlines in codeblocks#528
Conversation
✅ Deploy Preview for nimble-elf-d9d491 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Thank you, this is a good idea! It was like this because there was a conflicting checkstyle rule, but that was changed recently and wasn't applied everywhere I guess. Maybe using a regex to look for \}\n\n\t*\/\/ will suffice?
I don't think just that check will work (it might help though; catching some cases). Sometimes people use the |
…t solution though. Assuming `timeSinceDropped` was not supposed to be shown
|
I'm also noticing that a few of the codeblocks are displaying |
This one is waiting on an upstream pr iirc |
…d a workaround since file refrencing didn't seem possible. Someone should improve this.
This reverts commit 8f7b73f.
its-miroma
left a comment
its-miroma
left a comment
There was a problem hiding this comment.
Do please revert the changes to package-lock.json. You should notice that running npm i again will do just that.
|
Sorry, I was reviewing just as you pushed a commit reverting (: |
|
Okay I think that's all. I'm going to undraft this now |
4 participants
I noticed that some of the codeblocks have a trailing newline while most others don't. This extra newline also makes the codeblock slightly scrollable, which can be annoying if your mouse happens to be on a codeblock. I applied a fix on the items category, should I go through and fix all of them? or is this intentional for some reason?
See the third codeblock at https://docs.fabricmc.net/develop/items/first-item. There are many more besides this one example. Notice the scroll bar and the last line having a line number but it just being an empty newline.
after fix