fix(frontend): Fix inconsistent tooltip appearances and behaviours#7750
fix(frontend): Fix inconsistent tooltip appearances and behaviours#7750afsuyadi wants to merge 3 commits into
Conversation
|
@afsuyadi is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @afsuyadi pr look pretty good , here are some changes or suggestions that can be looked at:
|
SahilJat
left a comment
There was a problem hiding this comment.
Looks preety good , some changes can be considered (mentioned in the comment)
|
Thanks for the review @SahilJat , but I'll wait for the official maintainers' response. |
This comment was marked as spam.
This comment was marked as spam.
Zaimwa9
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Looks good but we will keep the identity overrides tooltip for now
| <Tooltip | ||
| title={ | ||
| <h5 className='mb-0'> | ||
| Identity Overrides{' '} | ||
| <Icon name='info-outlined' width={20} fill='#9DA4AE' /> | ||
| </h5> | ||
| } | ||
| place='top' | ||
| > | ||
| {Constants.strings.IDENTITY_OVERRIDES_DESCRIPTION} | ||
| </Tooltip> | ||
| <h5 className='mb-0'>Identity Overrides</h5> |
There was a problem hiding this comment.
If you don't mind, we'll revert this change. Because of the complexity of the concept, we will favor being overly verbose than not enough 👍
There was a problem hiding this comment.
Okay noted, please do. Thanks 👍
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #7703
Based on the acceptance criteria, these changes were made:
How did you test this code?
Before any changes:
Screencast+from+11-06-26+07_09_01.webm
Screencast.from.11-06-26.07.41.34.webm
After Changes:
Screencast from 11-06-26 08:10:08.webm
Additional note: I have checked other redundant items - where a Tooltip & InfoMessage with similar description exists - but none is found, only in the Identity Overrides tab. CMIIW