Feature/reference set by McDoyen · Pull Request #4 · FlockOfBirds/dropdown-type-ahead

McDoyen · 2018-11-26T07:14:57Z

Dropdown type ahead

codecov-io · 2018-11-27T13:21:10Z

Codecov Report

❗ No coverage uploaded for pull request base (master@c308cff). Click here to learn what that means.
The diff coverage is 48.2%.

@@           Coverage Diff            @@
##             master      #4   +/-   ##
========================================
  Coverage          ?   48.2%           
========================================
  Files             ?       4           
  Lines             ?     139           
  Branches          ?      40           
========================================
  Hits              ?      67           
  Misses            ?      72           
  Partials          ?       0

Impacted Files	Coverage Δ
src/SharedResources/components/Label.ts	`100% <100%> (ø)`
src/SharedResources/components/Alert.ts	`100% <100%> (ø)`
src/SharedResources/utils/ContainerUtils.ts	`11.32% <11.32%> (ø)`
.../DropdownReference/components/DropdownReference.ts	`62.68% <62.68%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c308cff...7349ba7. Read the comment docs.

Andries-Smit · 2018-12-05T08:31:37Z

+  "copyright": "Mendix BV",
+  "scripts": {
+    "start": "webpack-dev-server --hot --open",
+    "emit": "tsc",


"typeCheck": "tsc --noEmit",

Andries-Smit · 2018-12-05T08:32:31Z

+  "copyright": "Mendix BV",
+  "scripts": {
+    "start": "webpack-dev-server --hot --open",
+    "emit": "tsc",


Suggested change

"emit": "tsc",

"typeCheck": "tsc --noEmit",

no need to create files, it just pre-commit

Andries-Smit · 2018-12-05T08:32:47Z

+    "developmentPort": 3000
+  },
+  "pre-commit": [
+    "emit",


Suggested change

"emit",

"typeCheck",

Andries-Smit · 2018-12-05T08:34:02Z

+![badge](https://img.shields.io/badge/mendix-7.14.1-green.svg)
+
+# Dropdown
+An input widget used to display and edit associations


Suggested change

An input widget used to display and edit associations

An input widget used to display and edit associations for reference and reference sets

Andries-Smit · 2018-12-05T08:35:46Z

+
+    if (valueMap.selectType !== "asynchronous") {
+        visibilityMap.searchAttribute = false;
+    }


single line

visibilityMap.searchAttribute = valueMap.selectType !== "asynchronous" || valueMap.source === "xpath";

Andries-Smit · 2018-12-05T11:17:42Z

+
+export const Alert: FunctionComponent<AlertProps> = ({ bootstrapStyle, className, children }) =>
+    children
+        ? createElement("div", { className: classNames(`alert alert-${bootstrapStyle}`, className) }, children)


Suggested change

? createElement("div", { className: classNames(`alert alert-${bootstrapStyle}`, className) }, children)

? createElement("div", { className: classNames("alert", `alert-${bootstrapStyle}`, className) }, children)

Andries-Smit · 2018-12-05T11:18:55Z

+    orientation?: "horizontal" | "vertical";
+}
+
+export const Label: FunctionComponent<LabelProps> = ({ children, className, label, style, weight, orientation }) => {


Can we change it a HOC? handling both labeled and not labeled?

Andries-Smit · 2018-12-05T11:49:37Z

+    sortAttributes.map(optionObject => {
+        const { name, sort } = optionObject;
+        combined.push([ name, sort ]);
+    });


can this be simplified to

return sortAttributes.map(optionObject => [ optionObject.name, optionObject.sort ]);

Great. Fixed

Andries-Smit · 2018-12-05T11:50:48Z

@@ -0,0 +1,2 @@
+import * as WebdriverIO from "webdriverio";


rename to WebdriveIO.d.ts

Andries-Smit · 2018-12-05T11:51:52Z

+                `!/widgets/com/mendix/widget/custom/dropdown/DropdownReferenceSet.js`
+            ],
+            target: mxHost,
+            ws: true,


Remove ws: true,, is cause console error.

Stanley-Okwii and others added 30 commits July 18, 2018 19:12

Project setup

31fb108

Add WM configuration

4d0dc34

Add custom style: overdrive react-select default styles

0bc4339

Add overlay on open mendix form

18d6c35

Add onchange nanoflow and micrflow

735e548

Rename widget from ReferenceSelector to DropdownTypeaheadReference

e355dac

Add editable configuration

70b998c

Fetch attribute value associated with mendix object

2a8a3ac

Add styles when editable is disabled

147df23

Add error handling

2139279

Write up 'README' content

daeccb4

Add clearable feature to dropdown

806689b

Fix broken widget on listen to grid

ed78b11

Fix popup issue: set overflow to visible

c03deb4

Setup functional tests

993bc67

Fix bug: clear input with backspace key

2ffbb46

Fix bug: clear input with backspace key

23e6fe0

Merge branch 'feature/initial' of https://github.com/FlockOfBirds/dro…

2aebbb6

…pdown-type-ahead into tests/end-to-end

Merge branch 'feature/initial' of https://github.com/FlockOfBirds/dro…

43fa051

…pdown-type-ahead into tests/end-to-end

Fix web modeler

b30fc55

Fix bug: display selected option when fetching data is done

1ecaa50

Merge changes from initial branch

d23433d

Add label component

e6008e1

Fix webmodeler padding

37d4d70

Add custom input component

94491e2

Fix merge conflict

6a5fcd1

Remove input component

410c7eb

Add dropdown clear component

d1bb7de

Add control component

f8332e8

Add dropdown indicator component

0f5a98d

McDoyen force-pushed the feature/reference-set branch 2 times, most recently from 14a6ff9 to 55b9f0b Compare November 30, 2018 12:09

Fix e2e tests

4e28a45

McDoyen force-pushed the feature/reference-set branch from 55b9f0b to 4e28a45 Compare December 3, 2018 13:07

Refactor code

fb4654c

Andries-Smit requested changes Dec 5, 2018

View reviewed changes

Andries-Smit added 3 commits December 5, 2018 14:44

Fix prevent early options loading for async

b854f91

Add lazy contraint xpath start contains

a1f91a0

Improve xpath filter

baafc94

McDoyen force-pushed the feature/reference-set branch from 6af20b8 to 6cea6bd Compare December 6, 2018 14:28

Process feedback

79448b0

McDoyen force-pushed the feature/reference-set branch from 6cea6bd to 79448b0 Compare December 6, 2018 14:34

Add debounce

7b487f0

McDoyen force-pushed the feature/reference-set branch from cabca2e to 7b487f0 Compare December 7, 2018 14:18

Add widget art work

a034b9f

McDoyen force-pushed the feature/reference-set branch 3 times, most recently from b0eccb5 to a38e3e2 Compare December 14, 2018 06:11

Fix listen to grid

a8299ed

McDoyen force-pushed the feature/reference-set branch from a38e3e2 to a8299ed Compare December 14, 2018 07:00

Update documentation

bb1bb5b

McDoyen force-pushed the feature/reference-set branch 4 times, most recently from 35e5747 to 61f3673 Compare December 19, 2018 09:09

McDoyen force-pushed the feature/reference-set branch 2 times, most recently from 6f325a7 to 650c76f Compare December 21, 2018 12:44

Refactor code

7349ba7

McDoyen force-pushed the feature/reference-set branch from 650c76f to 7349ba7 Compare December 21, 2018 14:52

	An input widget used to display and edit associations
	An input widget used to display and edit associations for reference and reference sets

	? createElement("div", { className: classNames(`alert alert-${bootstrapStyle}`, className) }, children)
	? createElement("div", { className: classNames("alert", `alert-${bootstrapStyle}`, className) }, children)

Uh oh!

Conversation

McDoyen commented Nov 26, 2018

Uh oh!

codecov-io commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov-io commented Nov 27, 2018 •

edited

Loading