chore: drop redundant "r" mode argument to open() (ruff UP015)#164
Open
alexzhu0 wants to merge 1 commit intoFlowElement-ai:mainfrom
Open
chore: drop redundant "r" mode argument to open() (ruff UP015)#164alexzhu0 wants to merge 1 commit intoFlowElement-ai:mainfrom
alexzhu0 wants to merge 1 commit intoFlowElement-ai:mainfrom
Conversation
Ruff rule UP015 flags `open(path, "r", ...)` where the `"r"` mode is the default and thus redundant. Removing it is purely cosmetic — Python `open()` defaults to text-read mode when `mode` is omitted, so the behavior is byte-identical. Verification: - `uv run ruff check ... --select UP015` is now clean - ast.parse on every touched file: clean No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ruff rule UP015 flags
open(path, "r", ...)where the mode argument is redundant — Python'sopen()defaults tomode="r"(text-read) when the argument is omitted, so dropping the literal"r"is byte-identical. 9 occurrences, all auto-fixable.Semantic equivalence
Python's
open()docs state thatmodedefaults to"r":Removing the explicit
"r"leaves text-read mode unchanged. No positional/keyword argument shift either —encodingis already keyword-only in every touched site.Scope
9 files, 9 sites, +9 / −9 (pure argument removal).
examples/episodic_stage5_smoke_test.pym_flow/debug/trace_cli.pym_flow/eval/config.pym_flow/eval/loader.pym_flow/eval/report.pym_flow/llm/prompts/read_query_prompt.pym_flow/shared/loaders/core/csv_loader.pym_flow/shared/loaders/core/text_loader.pym_flow/tests/tasks/descriptive_metrics/metrics_test_utils.pyVerification
No behavior change. Generated code under
m_flow/baml_client/is untouched.I affirm that all code in every commit of this pull request conforms to the terms of the M-flow Developer Certificate of Origin