Skip to content

[BUGFIX] Fix event dropdown crashing when switching to another event#7767

Open
Infinite-SUDO67 wants to merge 1 commit into
FunkinCrew:developfrom
Infinite-SUDO67:code-changing
Open

[BUGFIX] Fix event dropdown crashing when switching to another event#7767
Infinite-SUDO67 wants to merge 1 commit into
FunkinCrew:developfrom
Infinite-SUDO67:code-changing

Conversation

@Infinite-SUDO67

Copy link
Copy Markdown

Linked Issues

#7766

Description

Fixed a crash in ChartEditorEventDataToolbox.hx where the game would error out if findComponent returned null. I replaced the buggy switch block with a simple if-else check using Std.isOfType. It’s much safer now and stops the editor from crashing when it tries to rebuild the form.

Screenshots/Videos

Gotta use Medal.tv cuz it exceeds 10MB
link: https://medal.tv/games/friday-night-funkin/clips/n7uQni31cp_IvgoIO?invite=cr-MSxFQ3AsNDM2NzU1ODA4

@github-actions github-actions Bot added pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. labels Jul 15, 2026
@NotHyper-474 NotHyper-474 added type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression topic: chart editor Related to the operation of the Chart Editor. labels Jul 15, 2026
@NotHyper-474

NotHyper-474 commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

What exactly was the need to remove the comments? You even removed documentation for a variable and a function, which are required by the check-style.

Also there's an odd git file included with the changes, I don't think that should be there.

@moxie-coder

moxie-coder commented Jul 15, 2026

Copy link
Copy Markdown

What exactly was the need to remove the comments? You even removed documentation for a variable and a function, which are required by the check-style.

Also there's an odd git file included with the changes, I don't think that should be there.

oops didn't realize you made this comment as I was writing lol

@Infinite-SUDO67

Copy link
Copy Markdown
Author

I'll fix it dw

@Infinite-SUDO67

Copy link
Copy Markdown
Author

might be done by tmr cuz i gotta add comment back and it 10am rn 😭 and am sleepy

@Infinite-SUDO67
Infinite-SUDO67 marked this pull request as draft July 16, 2026 00:29
@Infinite-SUDO67
Infinite-SUDO67 marked this pull request as ready for review July 16, 2026 00:55
@Infinite-SUDO67

Infinite-SUDO67 commented Jul 16, 2026

Copy link
Copy Markdown
Author

Done and W @kiryvajiravuth for helping me fixing

@moxie-coder moxie-coder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a lot better

@kiryvajiravuth

Copy link
Copy Markdown

Thanks mate

@kiryvajiravuth kiryvajiravuth left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon compiling and testing the code yeah it does fix the bug like it intended so yeah I approved of this

@Infinite-SUDO67

Copy link
Copy Markdown
Author

Went to fix the comment then got a compilation error in funkin preloader 😭 but thx mate for helping me rebase

@Hundrec Hundrec changed the title [CRASHFIX]: Event dropdown crash when switching to another event [BUGFIX] Fix event dropdown crashing when switching to another event Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression

Development

Successfully merging this pull request may close these issues.

4 participants