[BUGFIX] Fix event dropdown crashing when switching to another event#7767
[BUGFIX] Fix event dropdown crashing when switching to another event#7767Infinite-SUDO67 wants to merge 1 commit into
Conversation
|
What exactly was the need to remove the comments? You even removed documentation for a variable and a function, which are required by the check-style.
|
oops didn't realize you made this comment as I was writing lol |
|
I'll fix it dw |
|
might be done by tmr cuz i gotta add comment back and it 10am rn 😭 and am sleepy |
3712349 to
3a42939
Compare
|
Done and W @kiryvajiravuth for helping me fixing |
|
Thanks mate |
kiryvajiravuth
left a comment
There was a problem hiding this comment.
Upon compiling and testing the code yeah it does fix the bug like it intended so yeah I approved of this
|
Went to fix the comment then got a compilation error in funkin preloader 😭 but thx mate for helping me rebase |
Linked Issues
#7766
Description
Fixed a crash in ChartEditorEventDataToolbox.hx where the game would error out if findComponent returned null. I replaced the buggy switch block with a simple if-else check using Std.isOfType. It’s much safer now and stops the editor from crashing when it tries to rebuild the form.
Screenshots/Videos
Gotta use Medal.tv cuz it exceeds 10MB
link: https://medal.tv/games/friday-night-funkin/clips/n7uQni31cp_IvgoIO?invite=cr-MSxFQ3AsNDM2NzU1ODA4