trust the mapping of min & max during ore chunk prospecting#100
Draft
Sanduhr32 wants to merge 2 commits into
Draft
trust the mapping of min & max during ore chunk prospecting#100Sanduhr32 wants to merge 2 commits into
Sanduhr32 wants to merge 2 commits into
Conversation
also use constant instead of magic number
Author
|
@boubou19 how relevant is old ore gen still in 2.9 from old saves migrating? which version was the ore gen change? |
Algent
marked this pull request as draft
July 18, 2026 08:32
|
Setting it to draft before someone get a funny idea and it break again. Honestly the old oregen pattern code is still live in GT5-Unofficial so would have to be removed there first. Definitely not for 2.9 but huh 2.10 who know ? That said there is also the AOI for a new worldgen, plus the cubic chunk things. So maybe leave all that in until this drop, it's not like it cost a lot either as long as we don't re-break it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if the mapping of min/max for x & z works, then clearly the offets will always be mapped as well
also use the existing constant instead of random magic number
i randomly found this while also dealing with the broken prospecting
Checklist