test: fixes for precision and fragile tests from jax-galsim PR#1360
Open
beckermr wants to merge 1 commit into
Open
test: fixes for precision and fragile tests from jax-galsim PR#1360beckermr wants to merge 1 commit into
beckermr wants to merge 1 commit into
Conversation
Member
|
You'll need to remind me why these changes are necessary. They don't look particularly "fragile" to me. Why did we think these changes are appropriate? |
Contributor
Author
|
These changes came from your suggestions on the JAX-GalSim tests suite PR. Basically, we found that when things were implemented in JAX, the tests had to be changed. This was due to them demanding more precision than needed, sensitivity to the RNG seed, etc. |
Member
|
I thought we were moving those test changes to a different repo though... Am I misremembering the plan here? |
Contributor
Author
|
That was our plan, but the original comments you made during the code review indicated to me that these changes were needed in galsim as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has suggested changes to the main galsim test suite from the JAX-GalSim changes PR (#1252) that @rmjarvis reviewed for us a while back.