Feature/header behaviour#378
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for “replacement” semantics when applying security headers, allowing configured headers to overwrite existing response header values instead of always appending. This refactor centralizes header application logic in the middleware and propagates the new behavior through header compilation.
Changes:
- Refactors
SecurityHeaderMiddlewareto route header application through dedicated append/replace/remove handlers. - Introduces
HeaderDto.IsReplacementand ensures it’s preserved when headers are cloned per-request. - Marks custom headers with
CustomHeaderBehavior.Addas replacement headers when compiled for middleware application.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Stott.Security.Optimizely/Features/Middleware/SecurityHeaderMiddleware.cs | Refactors header application and adds explicit append/replace/remove handlers. |
| src/Stott.Security.Optimizely/Features/Header/HeaderDto.cs | Adds IsReplacement flag to support replace semantics. |
| src/Stott.Security.Optimizely/Features/Header/HeaderCompilationService.cs | Preserves IsReplacement when cloning headers for per-request mutation safety. |
| src/Stott.Security.Optimizely/Features/CustomHeaders/Service/CustomHeaderService.cs | Sets IsReplacement for “Add” custom headers so they overwrite existing values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.