Skip to content

fix(genai): resolve module path and naming issues in count-tokens samples#4321

Open
angelcaamal wants to merge 2 commits into
mainfrom
fix/genai-token-samples-imports
Open

fix(genai): resolve module path and naming issues in count-tokens samples#4321
angelcaamal wants to merge 2 commits into
mainfrom
fix/genai-token-samples-imports

Conversation

@angelcaamal
Copy link
Copy Markdown
Contributor

@angelcaamal angelcaamal commented May 22, 2026

Description

This PR addresses execution errors in the genai/count-tokens test suite.

Changes:

Path Corrections: Updated require statements in test files to correctly point to the corresponding sample source files.

Fixes Internal: b/517253756

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added samples Issues that are directly related to samples. generated: genai Contains Generative AI based code, requesting an additional reviewer. labels May 22, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates test files to align with renamed source files and the standardized countTokens function. A review comment identifies an inconsistency in the require statements where the .js extension was omitted in one file but retained in another, suggesting its restoration for repository-wide consistency.

Comment thread genai/count-tokens/test/counttoken-localtokenizer-compute-with-txt.test.js Outdated
@angelcaamal angelcaamal marked this pull request as ready for review May 22, 2026 20:06
@angelcaamal angelcaamal requested review from a team as code owners May 22, 2026 20:06
@XrossFox
Copy link
Copy Markdown

LGTM!

Copy link
Copy Markdown

@Kef131 Kef131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

generated: genai Contains Generative AI based code, requesting an additional reviewer. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants