Skip to content

Add animation curves support#4164

Open
Gavin-Niederman wants to merge 7 commits into
GraphiteEditor:masterfrom
Gavin-Niederman:add/animation-curves
Open

Add animation curves support#4164
Gavin-Niederman wants to merge 7 commits into
GraphiteEditor:masterfrom
Gavin-Niederman:add/animation-curves

Conversation

@Gavin-Niederman

@Gavin-Niederman Gavin-Niederman commented May 23, 2026

Copy link
Copy Markdown

A PR adding support for f-curves and a timeline NodeInput variant.

TODO:

  • AnimationCurve
  • Timeline NodeInput variant.
  • Store timeline curves in document

Demo

untitled.mp4

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an AnimationCurve implementation, featuring keyframe-based interpolation (Linear, Constant, and Bezier) and integration into the node graph system via new nodes and registry updates. Review feedback suggests refining the evaluation logic to clamp out-of-bounds values to the nearest keyframe for better consistency and optimizing keyframe insertion using binary search to improve performance and data validation.

Comment thread node-graph/libraries/core-types/src/animation.rs
Comment thread node-graph/libraries/core-types/src/animation.rs Outdated
Comment thread node-graph/libraries/core-types/src/animation.rs Outdated
@Keavon

Keavon commented May 23, 2026

Copy link
Copy Markdown
Member

Note: I rebased your branch.

@Keavon

Keavon commented Jun 8, 2026

Copy link
Copy Markdown
Member

Hey, just checking in on the latest with this, thanks!

@Gavin-Niederman

Copy link
Copy Markdown
Author

Hey, just checking in on the latest with this, thanks!

I haven't been able to do any development in a bit but im going to start working on this again now!

@Gavin-Niederman Gavin-Niederman force-pushed the add/animation-curves branch 3 times, most recently from 3d256ca to 89fe16f Compare June 25, 2026 00:21
@Gavin-Niederman Gavin-Niederman marked this pull request as ready for review June 25, 2026 01:11

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 7 files

Confidence score: 3/5

  • node-graph/libraries/core-types/src/animation.rs lets AnimationCurve derive Deserialize directly, which can bypass insert_keyframe ordering/finite-value/dedup invariants that evaluate() depends on for binary_search_by; merging as-is risks incorrect curve evaluation on deserialized data — add validated/custom deserialization (or post-deserialize normalization) before merging.
  • node-graph/preprocessor/src/lib.rs in replace_animation_curve_inputs does not skip eval_curve proto nodes, making the pass non-idempotent; repeated preprocessing can re-wrap/rewrite nodes and change graph behavior unexpectedly — add the missing guard and an idempotence regression test before merging.
  • node-graph/libraries/core-types/src/animation.rs also has a PR-title policy violation noted by automation, which is low product risk but can still block the integration path — rename the PR title to sentence case to clear the gate.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread node-graph/libraries/animation/src/lib.rs
Comment thread node-graph/preprocessor/src/lib.rs Outdated
Comment thread node-graph/libraries/animation/src/lib.rs
@Gavin-Niederman Gavin-Niederman changed the title add: animation curves support Add animation curves support Jun 25, 2026
@Gavin-Niederman Gavin-Niederman force-pushed the add/animation-curves branch 2 times, most recently from 37f9383 to da1d4f9 Compare June 26, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants