feat: improve Unreal Insights live analysis#244
Open
AiMiDi wants to merge 1 commit intoHKUDS:mainfrom
Open
Conversation
Collaborator
|
Thanks for the Unreal Insights work. I did not find a hard blocker in the code review, but I would adjust The remaining review risk is real-tool behavior with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve the existing Unreal Insights harness while keeping the harness/package version at v1 (
0.1.0).This adds Trace Store discovery, live UE process helpers with a pluggable command backend, GUI open/status helpers that keep Unreal Insights running, and
analyze summaryfor timing/counter exports. It also fixes UnrealInsights exporter filter quoting so wildcard filters such as--timers=*and--counter=*are passed as usableFParse::Tokenvalues instead of escaped literals.Fixes N/A
Type of Change
For Existing CLI Modifications
python -m pytest cli_anything/unrealinsights/tests/test_core.py -qpython -m pytest cli_anything/unrealinsights/tests/test_full_e2e.py -q -s -rs --tb=shortregistry.jsonentry is updated if version, description, or requirements changed (not changed; version remains0.1.0/ v1 by intent)General Checklist
--jsonflag is supported on any new commandsfeat:,fix:,docs:,test:)Test Results
Local environment:
D:\Program Files\Epic Games\UE_5.5\Engine\Binaries\Win64\UnrealInsights.exe, version5.5.4D:\Program Files\Epic Games\UE_5.5\Engine\Binaries\Win64\UnrealTraceServer.exe, version5.5example_trace.decomp.utraceUNREALINSIGHTS_TEST_TARGET_EXEwas not set, so real capture-launch E2E remains skippedCommands run:
Skip note: the single skipped test is the env-gated capture-launch test requiring a user supplied UE/game executable. The real exporter/analyze sample trace tests pass locally, including
timing-events,timer-stats,timer-callees, andcounter-values.