feat: add hacker-feeds-cli to registry#260
feat: add hacker-feeds-cli to registry#260collectivewinca wants to merge 3 commits intoHKUDS:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds new third-party harness CLIs to the CLI-Hub harness registry so they can be discovered and installed via cli-hub.
Changes:
- Adds a new
hacker-feeds-clientry (tech/news feed CLI wrapper). - Adds a new
ve-twinientry (Twitter/X CLI). - Reformats the surrounding tail of the registry (notably indentation around
openclaw-macroand the new entries).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "name": "ve-twini", | ||
| "display_name": "VE Twini", | ||
| "version": "1.0.0", | ||
| "description": "Unified Twitter/X CLI bridging bird (GraphQL API) and opencli (browser automation)", | ||
| "requires": "Python 3.10+, bird (Twitter API), opencli", | ||
| "homepage": "https://github.com/collectivewinca/ve-twini", | ||
| "source_url": "https://github.com/collectivewinca/ve-twini", | ||
| "install_cmd": "pip install git+https://github.com/collectivewinca/ve-twini.git#subdirectory=agent-harness", |
There was a problem hiding this comment.
The PR title/description mention only adding hacker-feeds-cli, but this diff also adds a new ve-twini registry entry. If intentional, please update the PR metadata; otherwise, remove the unrelated entry to keep the change scoped.
| { | ||
| "name": "haorui-harry", | ||
| "url": "https://github.com/haorui-harry" | ||
| "name": "openclaw-macro", | ||
| "display_name": "OpenClaw Macro System", | ||
| "version": "1.0.0", |
There was a problem hiding this comment.
These new CLI entries are indented more deeply than the surrounding clis array elements. While JSON ignores whitespace, the inconsistent formatting makes the registry harder to maintain and creates noisy diffs; please align the indentation with the rest of the file (array elements at the same level as safari).
| "install_cmd": "pip install git+https://github.com/collectivewinca/hacker-feeds-cli.git#subdirectory=cli_anything", | ||
| "entry_point": "cli-anything-hacker-feeds-cli", | ||
| "skill_md": "https://github.com/collectivewinca/hacker-feeds-cli/blob/main/cli_anything/hacker_feeds_cli/skills/SKILL.md", |
There was a problem hiding this comment.
hacker-feeds-cli uses pip install git+...#subdirectory=cli_anything and the SKILL.md URL points to .../cli_anything/.... The harness packaging convention in this repo expects an agent-harness/ directory containing setup.py and agent-harness/cli_anything/<software>/... (see cli-anything-plugin/HARNESS.md directory structure). If this is a standard harness, the subdirectory and SKILL.md path should reference agent-harness so pip installs from the correct package root and the skill link matches the canonical layout.
| "install_cmd": "pip install git+https://github.com/collectivewinca/hacker-feeds-cli.git#subdirectory=cli_anything", | |
| "entry_point": "cli-anything-hacker-feeds-cli", | |
| "skill_md": "https://github.com/collectivewinca/hacker-feeds-cli/blob/main/cli_anything/hacker_feeds_cli/skills/SKILL.md", | |
| "install_cmd": "pip install git+https://github.com/collectivewinca/hacker-feeds-cli.git#subdirectory=agent-harness", | |
| "entry_point": "cli-anything-hacker-feeds-cli", | |
| "skill_md": "https://github.com/collectivewinca/hacker-feeds-cli/blob/main/agent-harness/cli_anything/hacker_feeds_cli/skills/SKILL.md", |
|
Thanks for the Hacker Feeds registry entry. This one needs a few fixes before merge. The advertised repo URL is not reachable from GitHub right now ( Also, this PR includes the |
2e34fe7 to
00fdb99
Compare
|
Thanks for the review. I’ve addressed the requested fixes:
Please re-check when you have a moment. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00fdb9993b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "source_url": "https://github.com/collectivewinca/hacker-feeds-cli", | ||
| "install_cmd": "pip install git+https://github.com/collectivewinca/hacker-feeds-cli.git", | ||
| "entry_point": "cli-anything-hacker-feeds-cli", | ||
| "skill_md": "https://github.com/collectivewinca/hacker-feeds-cli/blob/main/cli_anything/hacker_feeds_cli/skills/SKILL.md", |
There was a problem hiding this comment.
Store
skill_md as a repo-relative path
The hub renderer always builds the Skill URL as ${REPO}/blob/main/${c.skill_md} (docs/hub/index.html:1004-1005), so putting a full GitHub URL in skill_md creates an invalid double-prefixed link and the Skill button will 404 for this CLI. In registry.json, skill_md needs to stay repo-relative (as with other entries) or the frontend must be updated to detect absolute URLs.
Useful? React with 👍 / 👎.
| "contributor_url": "https://github.com/rsasaki0109" | ||
| }, | ||
| { | ||
| "name": "hacker-feeds-cli", |
There was a problem hiding this comment.
Keep Hub source links pointing to an existing harness path
Hub cards generate the Source button from name as ${REPO}/tree/main/${c.name}/agent-harness (docs/hub/index.html:1007), but this new name has no matching directory in the repo (checked with rg --files | rg '^hacker-feeds-cli/', no matches). As a result, the Source link for this entry will be broken in production.
Useful? React with 👍 / 👎.
|
I addressed the two remaining Hub-link review comments in the latest push:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
docs/hub/index.html:1023
sourceHref()now supportsc.source_url, but the hub’s card rendering still only shows contributor info fromc.contributor/c.contributor_url(later in this function). With the newly added registry entry usingcontributors, the hub will render that CLI without any contributor section. Either update the rendering logic to handlecontributorsor standardize the registry schema back tocontributor/contributor_url.
const sourceLink = `<a href="${esc(sourceHref(c))}" target="_blank">Source</a>`;
const titleHtml = c.homepage
? `<a href="${esc(c.homepage)}" target="_blank">${esc(c.display_name)}${EXTERNAL_LINK_SVG}</a>`
: esc(c.display_name);
const isTeam = c.contributor === 'CLI-Anything-Team';
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "source_url": "https://github.com/collectivewinca/hacker-feeds-cli", | ||
| "install_cmd": "pip install git+https://github.com/collectivewinca/hacker-feeds-cli.git", | ||
| "entry_point": "cli-anything-hacker-feeds-cli", | ||
| "skill_md": "https://github.com/collectivewinca/hacker-feeds-cli/blob/main/cli_anything/hacker_feeds_cli/skills/SKILL.md", | ||
| "category": "search", | ||
| "contributors": [ | ||
| { | ||
| "name": "collectivewinca", | ||
| "url": "https://github.com/collectivewinca" | ||
| } | ||
| ] |
|
Addressed the latest schema comment in the newest push: hacker-feeds-cli now uses the existing contributor / contributor_url registry fields, so the Hub contributor rendering remains compatible. I kept source_url because the Hub now uses it specifically to support external source links. |
74e84ee to
c8ae4de
Compare
|
Thanks for the update. This PR now has merge conflicts because Please rebase this branch on the latest For
After resolving, please run a JSON validation on |
zhangxilong-43
left a comment
There was a problem hiding this comment.
I ran local validation/tests for this PR branch:
python3 -c "import json; json.load(open('registry.json'))"
- Result: PASS (
registry.json valid)
python3 .github/scripts/update_registry_dates.py
- Result: PASS (
Updated dates for 40 CLI entries) - Note:
hacker-feeds-cliis not included in generated dates (this is the P2 issue above).
python3 .github/scripts/generate_meta_skill.py
- Result: PASS (
Generated meta-skill with 42 CLIs)
python3 -m pytest -q cli-anything-plugin/tests/test_skill_generator.py
- Result: PASS (
31 passed)
python3 -m pytest -q skill_generation/tests/test_skill_path.py
- First run in sandbox failed due permission writing to
~/.cli-anything-demo - Re-run with elevated permission: PASS (
79 passed)
python3 -m pip install --dry-run --no-deps "git+https://github.com/collectivewinca/hacker-feeds-cli.git"
- Result: PASS (metadata resolves/builds successfully)
Add hacker-feeds-cli (tech news feeds) to CLI-Hub registry.