Add k8s portainer#848
Merged
mrnicegyu11 merged 2 commits intoITISFoundation:mainfrom Oct 22, 2024
Merged
Conversation
YuryHrytsuk
reviewed
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds k8s portainer to k8s.
This will require a sister-PR in osparc-config/e2e-ops for an e2e test before it is merged.is linked belowBonus:
Potential improvements are:
PORTAINER_USERandPORTAINER_PASSWORDfromrepo.config.template? This seems not immedeatly possible, see discussions in Add optional password secret portainer/k8s#72 and make admin password configurable in Helm Chart portainer/k8s#71Related issue/s
#819
Related PR/s
https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1017
Checklist