Skip to content

Enforce filter-expression permission by default in v2.17 - #10919

Merged
julianbrost merged 1 commit into
masterfrom
enfore-filter-expression-permission-by-default
Sep 16, 2026
Merged

julianbrost merged 1 commit into
masterfrom
enfore-filter-expression-permission-by-default

Conversation

@julianbrost

@julianbrost julianbrost commented Jun 30, 2026

Copy link
Copy Markdown
Member

This is a followup change for #10909, which was included in the v2.16.2, v2.15.4, and v2.14.9 releases and adds a new filter-expression permission to Icinga 2. As that's an incompatible change, this permission is not enforced by default yet (users need to opt-in), but the documentation and log messages already announce that this will change in v2.17.

This PR now adds exactly those changes: it changes the default of the (also newly added in #10909) enforce_filter_expression_permission config option to true and marks it as deprecated so that users are disencouraged from disabling it, but rather add the filter-expression to ApiUser objects instead. The documentation is also updated accordingly.

Our own API consumers should not be affected by this. I've asked about this (also in internal chats), and only Icinga DB, which - according to #10919 (review) - does not use filter expression, and Icinga Director, which asks for a wildcard permission, came up.

@julianbrost julianbrost added this to the 2.17.0 milestone Jun 30, 2026
@julianbrost julianbrost added the area/configuration DSL, parser, compiler, error handling label Jun 30, 2026
@cla-bot cla-bot Bot added the cla/signed label Jun 30, 2026
@julianbrost
julianbrost marked this pull request as draft July 1, 2026 10:16
@julianbrost

Copy link
Copy Markdown
Member Author

I wouldn't want to merge this just yet, see the TODO I added in the description (tl;dr: checking effects of the change on Icinga 2 API consumers like Icinga DB).

@Al2Klimov Al2Klimov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julianbrost
julianbrost force-pushed the enfore-filter-expression-permission-by-default branch from 457e5c2 to 4fb2778 Compare July 31, 2026 15:02
@julianbrost
julianbrost marked this pull request as ready for review July 31, 2026 15:02
@julianbrost

Copy link
Copy Markdown
Member Author

I wouldn't want to merge this just yet, see the TODO I added in the description (tl;dr: checking effects of the change on Icinga 2 API consumers like Icinga DB).

Should be fine, see updates PR description. I've also rebased for up-to-date GH Actions.

@julianbrost

Copy link
Copy Markdown
Member Author

Asked about this internally some time ago, got no complaints, and some hints that this should be fine. So merging this after a rebase for up-to-date actions.

@julianbrost
julianbrost force-pushed the enfore-filter-expression-permission-by-default branch from 4fb2778 to 9ea5012 Compare September 16, 2026 13:17
@julianbrost
julianbrost merged commit 3be2e74 into master Sep 16, 2026
23 checks passed
@julianbrost
julianbrost deleted the enfore-filter-expression-permission-by-default branch September 16, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/configuration DSL, parser, compiler, error handling cla/signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants