Enforce filter-expression permission by default in v2.17 - #10919
Merged
julianbrost merged 1 commit intoSep 16, 2026
Merged
Conversation
Al2Klimov
approved these changes
Jul 1, 2026
julianbrost
marked this pull request as draft
July 1, 2026 10:16
Member
Author
|
I wouldn't want to merge this just yet, see the TODO I added in the description (tl;dr: checking effects of the change on Icinga 2 API consumers like Icinga DB). |
Al2Klimov
approved these changes
Jul 14, 2026
Al2Klimov
left a comment
Member
There was a problem hiding this comment.
That's not how Icinga DB web filters objects:
julianbrost
force-pushed
the
enfore-filter-expression-permission-by-default
branch
from
July 31, 2026 15:02
457e5c2 to
4fb2778
Compare
julianbrost
marked this pull request as ready for review
July 31, 2026 15:02
Member
Author
Should be fine, see updates PR description. I've also rebased for up-to-date GH Actions. |
Member
Author
|
Asked about this internally some time ago, got no complaints, and some hints that this should be fine. So merging this after a rebase for up-to-date actions. |
julianbrost
force-pushed
the
enfore-filter-expression-permission-by-default
branch
from
September 16, 2026 13:17
4fb2778 to
9ea5012
Compare
julianbrost
deleted the
enfore-filter-expression-permission-by-default
branch
September 16, 2026 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup change for #10909, which was included in the v2.16.2, v2.15.4, and v2.14.9 releases and adds a new
filter-expressionpermission to Icinga 2. As that's an incompatible change, this permission is not enforced by default yet (users need to opt-in), but the documentation and log messages already announce that this will change in v2.17.This PR now adds exactly those changes: it changes the default of the (also newly added in #10909)
enforce_filter_expression_permissionconfig option totrueand marks it as deprecated so that users are disencouraged from disabling it, but rather add thefilter-expressiontoApiUserobjects instead. The documentation is also updated accordingly.Our own API consumers should not be affected by this. I've asked about this (also in internal chats), and only Icinga DB, which - according to #10919 (review) - does not use filter expression, and Icinga Director, which asks for a wildcard permission, came up.