fix(overview): custom tooltip position was impossible to select + use proper nk_edit#975
Open
sleeptightAnsiC wants to merge 1 commit into
Open
Conversation
… proper nk_edit For some reason the 'static' was missing from cur_pos preventing selection of custom tooltip position. This was broken since: Immediate-Mode-UI@0639685 Also fixed TODO note by using nk_edit_string_zero_terminated rather than reimplementing the wheel with text_len and '\0' Refs: Immediate-Mode-UI#900 Refs: Immediate-Mode-UI#937
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason the 'static' was missing from cur_pos preventing selection of custom tooltip position. This was broken since: 0639685
Also fixed TODO note by using nk_edit_string_zero_terminated rather than reimplementing the wheel with text_len and '\0'
(I also tried fixing #974 by using # in the properties and NK_EDIT_SIMPLE in nk_edit_, but that bug is a bigger problem than I thought... I decided to keep those changes in order to rule out all possibilities)
Refs: #900
Refs: #937