fix(annotations): Check for invalid sender requirements - #781
Merged
Conversation
Test Results 88 files ±0 88 suites ±0 11s ⏱️ -1s Results for commit d6d6a94. ± Comparison against base commit e8f9532. This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Citymonstret
approved these changes
Oct 18, 2025
There was a problem hiding this comment.
Pull request overview
This PR strengthens cloud-annotations’ annotation parsing by rejecting invalid requiredSender constraints up front, preventing misconfigured command methods from being registered with impossible sender requirements.
Changes:
- Add a validation step in
AnnotationParserthat throws anIllegalArgumentExceptionwhen@Command(requiredSender=...)is not a subtype of the parser’s configured command sender type. - Update/rename the required-sender test class and retain the
AnnotationParseras a field to reuse across test cases. - Add a new test asserting that an invalid
requiredSendervalue is rejected during parsing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cloud-annotations/src/main/java/org/incendo/cloud/annotations/AnnotationParser.java | Validates requiredSender is compatible with the configured command sender type and fails fast with a clear exception. |
| cloud-annotations/src/test/java/org/incendo/cloud/annotations/feature/RequiredSenderTest.java | Adds coverage for invalid requiredSender requirements and aligns the test class name with the file name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.