Skip to content

Fix production deploy config regeneration after remote migrations#9

Merged
Jamesllllllllll merged 5 commits intomainfrom
fix-prod-deploy
Mar 20, 2026
Merged

Fix production deploy config regeneration after remote migrations#9
Jamesllllllllll merged 5 commits intomainfrom
fix-prod-deploy

Conversation

@Jamesllllllllll
Copy link
Copy Markdown
Owner

@Jamesllllllllll Jamesllllllllll commented Mar 20, 2026

Summary

Fixes the production deploy workflow so the built frontend Wrangler config is regenerated after remote D1 migrations run, and updates the public search page to behave more like a browsable demo catalog. The search page now loads songs by default, shows a note of how many songs are currently available in the demo database, hides download counts from public-facing results, and displays the voice path as Lyrics in the UI.

What Changed

  • updated the production GitHub Actions workflow to rerun npm run deploy:prepare after npm run db:migrate:remote
  • ensured the final deploy steps use rebuilt production Wrangler configs instead of the source config written during the migration step
  • fixed the production deploy path that was causing the frontend deploy to fail on src/workers/app/index.ts
  • updated the public /search page to load a paginated list of available songs by default
  • removed the empty-search validation that was blocking default catalog browsing on /search
  • added an info alert on /search explaining that this is a demo and the database currently contains the number of songs that exist in the current DB
  • removed download counts from public-facing /search results
  • updated public-facing voice labels to display as Lyrics without changing stored path values or DB data

How To Test

  1. Push the branch and let GitHub Actions run.
  2. Confirm the production workflow reaches the frontend deploy step without the src/workers/app/index.ts missing-entrypoint error.
  3. Verify the frontend deploy uses the rebuilt .generated/wrangler.production.jsonc config.
  4. Open /search and confirm that songs are listed immediately without entering a query.
  5. Confirm the info alert appears and mentions that the current database only contains 50 songs.
  6. Verify pagination on /search still works.
  7. Confirm public /search results no longer show download counts.
  8. Confirm any public-facing voice path labels now display as Lyrics.
  9. After deploy, confirm the production app loads and search works again.

Screenshots Or UI Notes

The /search page now behaves more like a browsable catalog, includes an info alert noting that the current dataset is a 50-song demo, no longer shows download counts in public search results, and displays Lyrics instead of Voice in the UI.

Checklist

  • I tested the change locally
  • I updated docs or examples if needed
  • I called out any follow-up work or known limitations

@github-actions
Copy link
Copy Markdown

Preview deployment updated.

App: https://request-bot-pr-9.jameskeezer.workers.dev
Frontend worker: request-bot-pr-9
Backend worker: request-bot-backend-pr-9

@github-actions
Copy link
Copy Markdown

Preview deployment updated.

App: https://request-bot-pr-9.jameskeezer.workers.dev
Frontend worker: request-bot-pr-9
Backend worker: request-bot-backend-pr-9

@github-actions
Copy link
Copy Markdown

Preview deployment updated.

App: https://request-bot-pr-9.jameskeezer.workers.dev
Frontend worker: request-bot-pr-9
Backend worker: request-bot-backend-pr-9

@github-actions
Copy link
Copy Markdown

Preview deployment updated.

App: https://request-bot-pr-9.jameskeezer.workers.dev
Frontend worker: request-bot-pr-9
Backend worker: request-bot-backend-pr-9

@github-actions
Copy link
Copy Markdown

Preview deployment updated.

App: https://request-bot-pr-9.jameskeezer.workers.dev
Frontend worker: request-bot-pr-9
Backend worker: request-bot-backend-pr-9

@Jamesllllllllll Jamesllllllllll merged commit f9957cb into main Mar 20, 2026
2 checks passed
@Jamesllllllllll Jamesllllllllll deleted the fix-prod-deploy branch March 20, 2026 21:54
Jamesllllllllll added a commit that referenced this pull request Apr 12, 2026
Fix production deploy config regeneration after remote migrations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant