Skip to content

fix(DefaultUIController): guard SSL-error dialog against finishing activity (#1065) #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 1 commit into
base: androidx
Choose a base branch
from
Open

fix(DefaultUIController): guard SSL-error dialog against finishing activity (#1065) #1081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion agentweb-core/src/main/java/com/just/agentweb/DefaultUIController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,15 @@ public void onPermissionsDeny(String[] permissions, String permissionType, Strin

@Override
public void onShowSslCertificateErrorDialog(final WebView view, final SslErrorHandler handler, final SslError error) {
// Issue #1065: Activity may already be finishing/destroyed by the time the
// WebView delivers the SSL error callback on the main thread. Showing a
// dialog against a stale window token throws WindowManager$BadTokenException.
// Fail safe by cancelling the request when we cannot present UI.
if (mActivity == null || mActivity.isFinishing()
|| (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1 && mActivity.isDestroyed())) {
handler.cancel();
return;
}
Comment on lines +374 to +378
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elsewhere in this class you copy this.mActivity into a local Activity mActivity before checking/using it (e.g., onLoading()), which avoids repeated field reads and makes the null/finishing/destroyed checks consistent. Here the method uses the field directly and later calls mActivity.isFinishing() again without a null check; consider adopting the same local-variable pattern (and include activity == null in the second guard) for consistency and to avoid potential NPEs if mActivity changes.

Copilot uses AI. Check for mistakes.
AlertDialog.Builder alertDialog = new AlertDialog.Builder(mActivity);
String sslErrorMessage;
switch (error.getPrimaryError()) {
Expand Down Expand Up @@ -402,7 +411,18 @@ public void onClick(DialogInterface dialog, int which) {
handler.cancel();
}
});
alertDialog.show();
// Re-check just before show in case the activity transitioned during string lookup.
if (mActivity.isFinishing()
|| (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1 && mActivity.isDestroyed())) {
handler.cancel();
return;
}
try {
alertDialog.show();
} catch (android.view.WindowManager.BadTokenException | IllegalStateException e) {
// Activity window went away between our check and show(); fail safe.
handler.cancel();
}


}
Expand Down
Loading