fx(sonar): typescript:S7776: Use Set instead of Array for membership checks

Author: tplevko

packages/ui/src/components/Document/actions/utils.ts

@@ -4,9 +4,9 @@ import { DataMapperMetadataService } from '../../../services/datamapper-metadata
 import { DataMapperStepService } from '../../../services/datamapper-step.service';
 import { SchemaFileItem, SchemaFileMessage } from './AttachSchema/SchemaFileDataList';
 
-const VALID_XML_EXTENSIONS = ['.xml', '.xsd'];
-const VALID_JSON_EXTENSIONS = ['.json'];
-export const VALID_ALL_EXTENSIONS = [...VALID_XML_EXTENSIONS, ...VALID_JSON_EXTENSIONS];
+const VALID_XML_EXTENSIONS = new Set(['.xml', '.xsd']);
+const VALID_JSON_EXTENSIONS = new Set(['.json']);
+export const VALID_ALL_EXTENSIONS = new Set([...VALID_XML_EXTENSIONS, ...VALID_JSON_EXTENSIONS]);
 
 export function getFileExtension(filePath: string): string {
   return filePath.toLowerCase().substring(filePath.lastIndexOf('.'));
@@ -17,11 +17,11 @@ export function getFileName(filePath: string): string {
 }
 
 export function isXmlExtension(ext: string): boolean {
-  return VALID_XML_EXTENSIONS.includes(ext);
+  return VALID_XML_EXTENSIONS.has(ext);
 }
 
 export function isJsonExtension(ext: string): boolean {
-  return VALID_JSON_EXTENSIONS.includes(ext);
+  return VALID_JSON_EXTENSIONS.has(ext);
 }
 
 /** Public for tests only */
@@ -36,7 +36,7 @@ export async function validateFileExtension(ext: string, documentType: DocumentT
     }
     return undefined;
   }
-  if (!VALID_ALL_EXTENSIONS.includes(ext)) {
+  if (!VALID_ALL_EXTENSIONS.has(ext)) {
     return `Unknown file extension '${ext}'. Either XML schema (.xsd, .xml) or JSON schema (.json) file is supported.`;
   }
   return undefined;

packages/ui/src/components/Visualization/Canvas/Form/fields/MediaTypeField/MediaTypeField.tsx

@@ -15,7 +15,7 @@ import { FunctionComponent, KeyboardEvent, MouseEvent, Ref, useCallback, useCont
 
 import { SettingsContext } from '../../../../../../providers/settings.provider';
 
-const COMMON_MEDIA_TYPES = [
+const COMMON_MEDIA_TYPES = new Set([
   'application/json',
   'application/xml',
   'text/plain',
@@ -49,7 +49,7 @@ const COMMON_MEDIA_TYPES = [
   'application/senml+xml',
   'application/pkcs7-mime',
   'application/pkcs7-signature',
-];
+]);
 
 const parseMediaTypes = (value: string | undefined): string[] => {
   if (!value) {
@@ -76,7 +76,7 @@ export const MediaTypeField: FunctionComponent<FieldProps> = ({ propName, requir
   const selectedValues = useMemo(() => parseMediaTypes(value), [value]);
 
   const options = useMemo(() => {
-    const customValues = selectedValues.filter((item) => !COMMON_MEDIA_TYPES.includes(item));
+    const customValues = selectedValues.filter((item) => !COMMON_MEDIA_TYPES.has(item));
     const merged = new Set<string>([...COMMON_MEDIA_TYPES, ...storedMediaTypes, ...customValues]);
     return Array.from(merged);
   }, [selectedValues, storedMediaTypes]);