Support new and legacy IDA SDK library layouts regardless of version#59
Merged
Conversation
- Remove global `-flto` from `src/CMakeLists.txt` - Detect compiler-less IDA SDK library directories - Add Linux `aarch64` mapping to IDA `arm64` library paths - Keep compiler suffixes for older SDK library layouts Co-authored-by: Dimitar Kolev <dimitarkolev@tutanota.com>
- Normalize directive spacing and indentation in `src/ida_plugin.cmake` - Align target and link calls without changing CMake behavior Co-authored-by: Dimitar Kolev <dimitarkolev@tutanota.com>
- Move platform branches to set architecture, platform, compiler, and link metadata - Probe `plain`, `compiler`, and `compiler_pro` SDK layouts with `EXISTS` - Validate selected SDK library paths before linking - Reject unsupported `CMAKE_SYSTEM_NAME` values explicitly - Share `TARGET_LINK_LIBRARIES` calls across supported platforms Co-authored-by: Dimitar Kolev <dimitarkolev@tutanota.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
ida_plugin.cmaketo support newer IDA SDK library layouts while keeping compatibility with older SDKs.Features
aarch64host detection mapped to IDA SDKarm64dirsNote
Only relevant on versions of IDA SDK which include HexRaysSA/ida-sdk#39
Changes
EXISTSinstead of relying on SDK version guessesx64_linux_64x64_linux_gcc_64x64_linux_gcc_64_pro-flto; linking already passes LTO flags where neededTARGET_LINK_LIBRARIESselection across platformsida_plugin.cmakeTesting
Tested with a CMake matrix covering:
_proSDK layoutsUNI64=ONandUNI64=OFFAlso verified the plugin builds with IDA SDK 9.3 on Linux.