Add raw text dataset support to ActivationsStore#11
Open
HowardHsuuu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for using either pre-tokenized datasets or raw text datasets in
ActivationsStore.The existing
is_dataset_tokenizedconfig option is now respected:is_dataset_tokenized=True: preserves the current behavior and reads token IDs fromtokensorinput_idsis_dataset_tokenized=False: reads raw text fromdataset_text_columnand tokenizes lazily withmodel.tokenizerBoth paths are normalized into the same token stream before batching and activation generation, so the downstream activation/training pipeline does not need to know whether the source dataset was raw text or pre-tokenized.
Also included:
dataset_text_columntoCLTTrainingRunnerConfigandAutoInterpConfiggenerate_and_save_activations(number_of_tokens=None)to work with raw text datasetsTests
Added focused tests in
tests/training/test_activation_store_dataset_tokens.py.These cover:
tokensinput_idstotokensmodel.tokenizerdataset_text_columnActivationsStoreiteration for both raw and pre-tokenized datasetsgenerate_and_save_activations(number_of_tokens=None)