Fix favorites star spinning indefinitely after click on Project Hub

[Copilot]

Clicking the favorite star added a go spinner class but hx-swap="none" meant no DOM update ever occurred to remove it, leaving the animation running forever.

Change

Added hx-on::after-request to the favorite button in projectCard.blade.php to remove the go class as soon as the HTMX request settles:

hx-on::after-request="jQuery(this).removeClass('go')"

The star icon state continues to update correctly via the existing HTMX.updateProjectList event fired by toggleFavorite(), which refreshes the project list. No backend changes required.

Original prompt

Fix the favorites star button on the Project Hub page that spins indefinitely after clicking.

Issue: #3363

Root cause: In app/Domain/Projects/Templates/partials/projectCard.blade.php, the favorite button uses:

• onclick="jQuery(this).addClass('go')" to add a spinner animation
• hx-swap="none" which prevents htmx from replacing any DOM content
• The backend toggleFavorite() in app/Domain/Projects/Hxcontrollers/ProjectCard.php fires an HTMX.updateProjectList event, but the go class is never removed because no DOM swap occurs

Fix approach: The simplest fix is to change hx-swap="none" to properly swap the project card content so the spinner is replaced by the updated card. Alternatively, add htmx event hooks to remove the go class after the request completes.

Specifically:

1. In app/Domain/Projects/Templates/partials/projectCard.blade.php, change the favorite button's hx-swap attribute from "none" to "outerHTML" on the hx-target, OR add an hx-on::after-request attribute that removes the go class: hx-on::after-request="jQuery(this).removeClass('go')"
2. Ensure the star icon toggles between fa-solid and fa-regular in the response
3. Do NOT modify any backend logic — the toggleFavorite() method works correctly

Keep the change minimal — only modify the template file to fix the UI feedback loop.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}