Skip to content

Update confirmation message for app deletion#5214

Closed
mvanamburg wants to merge 1 commit into
LizardByte:masterfrom
mvanamburg:master
Closed

Update confirmation message for app deletion#5214
mvanamburg wants to merge 1 commit into
LizardByte:masterfrom
mvanamburg:master

Conversation

@mvanamburg
Copy link
Copy Markdown

@mvanamburg mvanamburg commented May 29, 2026

Description

"Are you sure to delete " - > "Are you sure you want to delete"

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

 "Are you sure to delete "  - > "Are you sure you want to delete"
@sonarqubecloud
Copy link
Copy Markdown

@ReenigneArcher
Copy link
Copy Markdown
Member

Thank you for the PR! This should actually be moved to the en.json file.

@mvanamburg
Copy link
Copy Markdown
Author

mvanamburg commented May 29, 2026

If I were to add this to the en.json file as, for example, "app_delete_confirmation" and then make apps.html refer to app_delete_confirmation, wouldn't translations for other languages need to be added as well?

@ReenigneArcher
Copy link
Copy Markdown
Member

@ReenigneArcher ReenigneArcher added this to the stable release milestone May 29, 2026
@Noklef
Copy link
Copy Markdown
Contributor

Noklef commented May 30, 2026

FYI: this is fixed in my MR with the new modal UI flow ( already set within en.json for translation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants