fix(ci): add Go, TinyGo setup to release workflow - #1139
Merged
Conversation
The release workflow runs pnpm build which triggers build:wasm via turbo, but was missing Go/TinyGo setup and contract type generation. Copy these steps from build.yml.
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Release workflow (
release.yml) runspnpm buildwhich triggersbuild:wasmvia turbo, but was missing Go/TinyGo setup and contract type generation. These steps exist inbuild.ymlbut were never copied torelease.yml, causingsh: 1: tinygo: not foundduring release builds.Added:
actions/setup-go@v5(Go 1.24)acifani/setup-tinygo@v2(TinyGo 0.36.0)TINYGOROOT,TINYGOPATH)pnpm --filter=@lumeweb/lbry-sdk generate)What changed
Updated the release workflow (
.github/workflows/release.yml) so the release job can build the parts of the project that depend on Go/TinyGo:TINYGOROOTandTINYGOPATH.pnpm --filter=@lumeweb/lbry-sdk generatebefore the main build step.Why
The release build requires TinyGo-based generation to run, but the workflow was missing the Go/TinyGo toolchain setup. This change ensures the release job can fully build and publish the project.