Skip to content

chore(palette): migrate highcharts impls from Okabe-Ito to imprint#7796

Merged
MarkusNeusinger merged 1 commit into
mainfrom
chore/migrate-imprint-highcharts
May 27, 2026
Merged

chore(palette): migrate highcharts impls from Okabe-Ito to imprint#7796
MarkusNeusinger merged 1 commit into
mainfrom
chore/migrate-imprint-highcharts

Conversation

@MarkusNeusinger
Copy link
Copy Markdown
Owner

Summary

  • Positional hex + rgba replacement across 146 highcharts impls with light+dark renders.
  • Proactive semantic-anchor fixes for 11 highcharts impls (red/amber/green where slot-1 lavender broke meaning, plus span-basic's "Financial Crisis" band restored to semantic red).

Test plan

  • ruff check . + format green
  • CI green
  • Copilot triage
  • After merge: Stage B for 146 highcharts impls → GCS

🤖 Generated with Claude Code

Positional hex + rgba replacement across 146 highcharts impls with
light+dark renders. Mirrors all earlier library passes.

Proactive semantic-anchor fixes for 11 highcharts impls:

- bar-diverging          NEGATIVE          → red
- gauge-basic            ZONE_LOW/MID      → red/amber traffic-light
- horizon-basic          colors_neg ramp   → imprint red ramp (light→mid→dark)
- indicator-macd         SIGNAL_COLOR      → ochre (categorical contrast)
- kagi-basic             YIN_COLOR         → red
- point-and-figure-basic BEAR              → red
- renko-basic            BEARISH           → red
- shap-waterfall         POSITIVE_COLOR    → red
- span-basic             "Financial Crisis" band + label → red
                         (semantic danger; the original Okabe vermillion
                         already read as warning/red, the positional swap
                         had turned it into a neutral lavender)
- waterfall-basic        NEGATIVE_COLOR    → red

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 27, 2026 23:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@MarkusNeusinger MarkusNeusinger merged commit 18a784e into main May 27, 2026
7 of 8 checks passed
@MarkusNeusinger MarkusNeusinger deleted the chore/migrate-imprint-highcharts branch May 27, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants