Skip to content

chore(palette): migrate letsplot impls from Okabe-Ito to imprint#7797

Merged
MarkusNeusinger merged 1 commit into
mainfrom
chore/migrate-imprint-letsplot
May 27, 2026
Merged

chore(palette): migrate letsplot impls from Okabe-Ito to imprint#7797
MarkusNeusinger merged 1 commit into
mainfrom
chore/migrate-imprint-letsplot

Conversation

@MarkusNeusinger
Copy link
Copy Markdown
Owner

Summary

  • Positional hex + rgba replacement across 138 letsplot impls with light+dark renders.
  • Final Python library in the imprint migration. R + Julia (ggplot2 + makie) still to come.
  • Proactive semantic-anchor fixes for 12 letsplot impls.

Test plan

  • ruff check . + format green
  • CI green
  • Copilot triage
  • After merge: Stage B for 138 letsplot impls → GCS

🤖 Generated with Claude Code

Positional hex + rgba replacement across 138 letsplot impls with
light+dark renders. Final Python library — mirrors the matplotlib,
seaborn, plotnine, plotly, bokeh, altair, pygal, highcharts passes.

Proactive semantic-anchor fixes for 12 letsplot impls where slot-1
(now lavender) carried explicit semantic meaning:

- bar-diverging          NEGATIVE_COLOR    → red
- candlestick-volume     color_down        → red
- horizon-basic          neg full-intensity → red
- indicator-macd         Negative fill→red, SECONDARY signal line→ochre
- ohlc-bar               DOWN_COLOR        → red
- point-and-figure-basic "down" scale color → red
- renko-basic            BEARISH           → red
- residual-plot          OUTLIER_COLOR     → red
- shap-waterfall         POS_COLOR         → red
- slope-basic            COLOR_DECREASE    → red
- volcano-basic          Up-regulated → red, Down-regulated stays blue

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 27, 2026 23:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@MarkusNeusinger MarkusNeusinger merged commit 37b1793 into main May 27, 2026
7 of 8 checks passed
@MarkusNeusinger MarkusNeusinger deleted the chore/migrate-imprint-letsplot branch May 27, 2026 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants