chore: untrack rendered plot artifacts + commit Julia Manifest#7835
Merged
Conversation
Two cleanup items from the imprint migration:
1. Untrack 18 rendered plot artifacts that had accidentally been
committed under plots/*/implementations/*/plot-*.{png,html} during
earlier daily-regen passes. The canonical home for these is GCS
production (gs://anyplot-images/plots/...); the impl files render
into .regen-preview/ during Stage B, which is already gitignored.
Adding an explicit .gitignore rule for the impl-dir-root path so
the same regression can't sneak in again — this catches the case
where an impl calls savefig(script_dir, ...) instead of plain cwd.
Affected specs (all had stale Okabe-Ito renders sitting next to
the impl files):
- maze-printable, network-directed, spectrum-basic,
streamline-basic, subplot-grid, timeseries-decomposition (python)
- ohlc-bar (r)
2. Commit the Julia Manifest.toml lockfile. Project.toml says it
"should be committed alongside this file once Julia has run
Pkg.instantiate() for the first time" — that first run happened
locally for the makie Stage B in the imprint migration. Pinning
it now makes CI / future local installs reproducibly resolve to
the same 311-package dependency tree (CairoMakie, CSV, Colors,
transient deps).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two cleanup items surfaced by the imprint migration:
Untrack 18 stale rendered plot artifacts that had accidentally been committed under
plots/*/implementations/*/plot-*.{png,html}during earlier daily-regen passes. Canonical home for rendered plots is GCS production (gs://anyplot-images/plots/...); impl files render into.regen-preview/during Stage B (already gitignored). Adds an explicit.gitignorerule for the impl-dir-root path so this can't recur — catches impls that callsavefig(script_dir, ...)instead of plaincwd.Affected specs:
Commit Julia
Manifest.tomllockfile.Project.tomlsays it "should be committed alongside this file once Julia has runPkg.instantiate()for the first time" — that first run happened locally for the makie Stage B in the imprint migration. Pinning the resolved tree (311 deps: CairoMakie, CSV, Colors + transient) makes CI / future local installs reproducible.Test plan
ruff check .green🤖 Generated with Claude Code