Skip to content

feat(impl-generate): enable interactive HTML previews for JavaScript libs #8251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkusNeusinger merged 1 commit into from
Jun 2, 2026
Merged

feat(impl-generate): enable interactive HTML previews for JavaScript libs #8251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/impl-generate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,11 +649,18 @@ jobs:
fi
echo "::notice::Library version: $LIBRARY = $LIBRARY_VERSION ($LANGUAGE runtime $LANGUAGE_VERSION, pipeline python $PYTHON_VERSION)"

# Interactive libraries additionally produce HTML previews (one per theme)
# Interactive libraries additionally produce HTML previews (one per theme).
# Python interactive libs are listed explicitly. JavaScript libs are
# interactive too (the browser render harness emits standalone
# plot-{light,dark}.html) — but gate on the files actually existing, so a
# lib/render that produced no HTML never points preview_html at a 404.
HAS_HTML="false"
case "$LIBRARY" in
plotly|bokeh|altair|highcharts|pygal|letsplot) HAS_HTML="true" ;;
esac
if [ "$LANGUAGE" = "javascript" ] && [ -f "$IMPL_DIR/plot-light.html" ] && [ -f "$IMPL_DIR/plot-dark.html" ]; then
HAS_HTML="true"
fi

# Write metadata file using Python for proper YAML formatting
# Pass all variables inline to avoid export/env issues
Expand Down Expand Up @@ -943,6 +950,13 @@ jobs:
HTML_DARK="${BASE}/plot-dark.html"
;;
esac
# JS libs are interactive too — link the HTML only when the render
# produced it (mirrors the existence gate used for preview_html).
IMPL_DIR="plots/${SPEC_ID}/implementations/${LANGUAGE}"
if [ "$LANGUAGE" = "javascript" ] && [ -f "$IMPL_DIR/plot-light.html" ] && [ -f "$IMPL_DIR/plot-dark.html" ]; then
HTML_LIGHT="${BASE}/plot-light.html"
HTML_DARK="${BASE}/plot-dark.html"
fi

BODY="## :art: ${LANGUAGE}/${LIBRARY} Preview

Expand Down
Loading