Skip to content

fix(frontend): library-card descriptions for chartjs, d3, echarts #8254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkusNeusinger merged 1 commit into from
Jun 2, 2026
Merged

fix(frontend): library-card descriptions for chartjs, d3, echarts #8254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/src/components/LibraryCard.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ describe('LibraryCard', () => {
expect(screen.getByText('matplotlib')).toBeInTheDocument();
});

it('renders the description for a javascript library', () => {
render(<LibraryCard name="echarts" language="javascript" onClick={vi.fn()} />);
expect(screen.getByText(/Powerful interactive charts for the browser/i)).toBeInTheDocument();
});

it('renders the language chip in the corner when language is provided', () => {
render(<LibraryCard name="ggplot2" language="r" onClick={vi.fn()} />);
expect(screen.getByLabelText('Language: R')).toHaveTextContent('R');
Expand Down
3 changes: 3 additions & 0 deletions app/src/components/LibraryCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ const DESCRIPTIONS: Record<string, string> = {
letsplot: 'Grammar of graphics by JetBrains. Interactive.',
ggplot2: 'The reference grammar of graphics. R’s expressive plotting standard.',
makie: 'High-performance Julia visualization. CairoMakie ships publication-quality static charts.',
chartjs: 'Simple, flexible HTML5-canvas charts. The popular JS default.',
d3: 'Data-driven SVG. Low-level, maximum control on the web.',
echarts: 'Powerful interactive charts for the browser. Vast chart catalog.',
};

interface LibraryCardProps {
Expand Down
Loading